# Re: \[PATCH 1/6\] OMAPDSS: DISPC: Remove cpu\_is\_xxxx checks

- From: Tomi Valkeinen \<hidden\>
- Date: 2012-08-07 10:57:26 
- List: linux-omap
- Page: https://ratatoskr.run/linux-omap/2012/08/13463594
- Thread: https://ratatoskr.run/linux-omap/2012/08/13463753/t.md

```text
On Tue, 2012-08-07 at 13:27 +0300, Felipe Balbi wrote:
> Hi,

> > Yes, they can be overridden, but I think it's still quite difficult to
> > manage. DSS is modeled with multiple blocks, also in DT data. So you'd
> > need to override multiple entries.
> > 
> > And it'd also require a new dts file for each version of your board with
> > different ES version.
> > 
> > Also, I don't really see why this information would need to be present
> > in the DT data (especially as it's not simple). It's all trivially found
> > out in the code, by using cpu_is & soc_is.
> 
> Fair enough. I just think we should remove all cpu_is_* and soc_is_*
> from drivers.

I agree, that's part of the idea here. Instead of having cpu_is checks
all around, we'll have them in only certain centralized places. Then
it's easier to implement a way to move them totally out of the driver,
when we come up with a good idea how to accomplish that.

 Tomi

```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-omap/2012/08/13463594/attachment/0) (application/pgp-signature, 836 bytes)