# Re: \[PATCH 03/16\] ARM: omap: fix broken twl-core dependencies and ifdefs

- From: Tony Lindgren \<tony@atomide.com\>
- Date: 2012-02-08 18:38:22 
- List: linux-omap
- Page: https://ratatoskr.run/linux-omap/2012/02/15519516
- Thread: https://ratatoskr.run/linux-omap/2012/02/8596648/t.md

```text
* Russell King - ARM Linux [ref] [120208 08:05]:
> In commit aeb5032b3f, a dependency on IRQ_DOMAIN was added, which causes
> regressions on previously working setups: a previously working non-DT
> kernel configuration now loses its PMIC support.  The lack of PMIC
> support in turn causes the loss of other functionality the kernel had.
> 
> This dependency was added because the driver now registers its
> interrupts with the IRQ domain code, presumably to prevent a build error.
> 
> The result is that OMAP3 oopses in the vp.c code (fixed by a previous
> commit) due to the lack of PMIC support.
> 
> However, even with IRQ_DOMAIN enabled, the driver oopses:
...
> 
> Signed-off-by: Russell King <redacted>

This should be checked that it compiles on other platforms like x86.

Other than that:

Acked-by: Tony Lindgren <tony@atomide.com>
```