[PATCH] nvme-pci: add BOGUS_NID for Intel 0a54 device

Subsystems: nvm express driver, the rest

STALE1089d

2 messages, 2 authors, 2023-10-13 · open the first message on its own page

[PATCH] nvme-pci: add BOGUS_NID for Intel 0a54 device

From: Keith Busch <hidden>
Date: 2023-10-12 18:30:11

From: Keith Busch <kbusch@kernel.org>

These ones claim cmic and nmic capable, so need special consideration to ignore
their duplicate identifiers.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217981
Reported-by: welsh@cassens.com
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 drivers/nvme/host/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 60a08dfe8d75f..507bc149046dc 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3328,7 +3328,8 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_VDEVICE(INTEL, 0x0a54),	/* Intel P4500/P4600 */
 		.driver_data = NVME_QUIRK_STRIPE_SIZE |
 				NVME_QUIRK_DEALLOCATE_ZEROES |
-				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
+				NVME_QUIRK_IGNORE_DEV_SUBNQN |
+				NVME_QUIRK_BOGUS_NID, },
 	{ PCI_VDEVICE(INTEL, 0x0a55),	/* Dell Express Flash P4600 */
 		.driver_data = NVME_QUIRK_STRIPE_SIZE |
 				NVME_QUIRK_DEALLOCATE_ZEROES, },
-- 
2.34.1

Re: [PATCH] nvme-pci: add BOGUS_NID for Intel 0a54 device

From: Christoph Hellwig <hch@lst.de>
Date: 2023-10-13 04:31:33

On Thu, Oct 12, 2023 at 11:29:34AM -0700, Keith Busch wrote:
From: Keith Busch <kbusch@kernel.org>

These ones claim cmic and nmic capable, so need special consideration to ignore
*sigh*.

The patch looks fine except that the above line should be trimmed a bit.

Reviewed-by: Christoph Hellwig <hch@lst.de>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help