[PATCH] kNFSd - 3 of 4 - A couple of possible incorrect calls to dput....

DORMANTno replies

From: NeilBrown <hidden>
Date: 2002-10-11 00:22:46

### Comments for ChangeSet

Thanks to Hirokazu Takahashi [off-list ref]





 ----------- Diffstat output ------------
 ./fs/exportfs/expfs.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)
--- ./fs/exportfs/expfs.c	2002/10/10 23:07:32	1.1
+++ ./fs/exportfs/expfs.c	2002/10/10 23:07:34	1.2
@@ -183,12 +183,12 @@ find_exported_dentry(struct super_block 
 			err = CALL(nops,get_name)(ppd, nbuf, pd);
 			if (err) {
 				dput(ppd);
+				dput(pd);
 				if (err == -ENOENT)
 					/* some race between get_parent and
 					 * get_name?  just try again
 					 */
 					continue;
-				dput(pd);
 				break;
 			}
 			dprintk("find_exported_dentry: found name: %s\n", nbuf);
@@ -254,6 +254,7 @@ find_exported_dentry(struct super_block 
 		return result;
 	/* one last try of the aliases.. */
 	spin_lock(&dcache_lock);
+	toput = NULL;
 	head = &result->d_inode->i_dentry;
 	list_for_each(le, head) {
 		struct dentry *dentry = list_entry(le, struct dentry, d_alias);


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help