linux-next: build warning after merge of the block tree

4 messages, 2 authors, 2021-09-03 · open the first message on its own page

linux-next: build warning after merge of the block tree

From: Stephen Rothwell <hidden>
Date: 2021-08-13 09:41:22

Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

block/bio.c:1689: warning: Function parameter or member 'nr_vecs' not described in 'bio_alloc_kiocb'

Introduced by commit

  1cbbd31c4ada ("bio: add allocation cache abstraction")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the block tree

From: Jens Axboe <axboe@kernel.dk>
Date: 2021-08-13 13:55:01

On 8/13/21 3:41 AM, Stephen Rothwell wrote:
Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

block/bio.c:1689: warning: Function parameter or member 'nr_vecs' not described in 'bio_alloc_kiocb'

Introduced by commit

  1cbbd31c4ada ("bio: add allocation cache abstraction")
Thanks, fixed up.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the block tree

From: Stephen Rothwell <hidden>
Date: 2021-09-03 06:49:46

Hi Jens,

On Fri, 13 Aug 2021 07:54:51 -0600 Jens Axboe [off-list ref] wrote:
On 8/13/21 3:41 AM, Stephen Rothwell wrote:
quoted
Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

block/bio.c:1689: warning: Function parameter or member 'nr_vecs' not described in 'bio_alloc_kiocb'

Introduced by commit

  1cbbd31c4ada ("bio: add allocation cache abstraction")  
Thanks, fixed up.
Not really :-(  I am now also getting this (the above has moved to line
1704 as well):

block/bio.c:1704: warning: Excess function parameter 'nr_iovecs' description in 'bio_alloc_kiocb'

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the block tree

From: Jens Axboe <axboe@kernel.dk>
Date: 2021-09-03 13:41:39

On 9/3/21 12:49 AM, Stephen Rothwell wrote:
Hi Jens,

On Fri, 13 Aug 2021 07:54:51 -0600 Jens Axboe [off-list ref] wrote:
quoted
On 8/13/21 3:41 AM, Stephen Rothwell wrote:
quoted
Hi all,

After merging the block tree, today's linux-next build (htmldocs)
produced this warning:

block/bio.c:1689: warning: Function parameter or member 'nr_vecs' not described in 'bio_alloc_kiocb'

Introduced by commit

  1cbbd31c4ada ("bio: add allocation cache abstraction")  
Thanks, fixed up.
Not really :-(  I am now also getting this (the above has moved to line
1704 as well):

block/bio.c:1704: warning: Excess function parameter 'nr_iovecs' description in 'bio_alloc_kiocb'
This should fix that one up:
diff --git a/block/bio.c b/block/bio.c
index e16849f46b0e..5df3dd282e40 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1688,7 +1688,7 @@ EXPORT_SYMBOL(bioset_init_from_src);
 /**
  * bio_alloc_kiocb - Allocate a bio from bio_set based on kiocb
  * @kiocb:	kiocb describing the IO
- * @nr_iovecs:	number of iovecs to pre-allocate
+ * @nr_vecs:	number of iovecs to pre-allocate
  * @bs:		bio_set to allocate from
  *
  * Description:
-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help