linux-next: build warning after merge of the mailbox tree

2 messages, 2 authors, 2021-06-21 · open the first message on its own page

linux-next: build warning after merge of the mailbox tree

From: Stephen Rothwell <hidden>
Date: 2021-06-21 05:57:57

Hi all,

After merging the mailbox tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from drivers/mailbox/mailbox-mpfs.c:19:
include/soc/microchip/mpfs.h:43:12: warning: 'mpfs_blocking_transaction' defined but not used [-Wunused-function]
   43 | static int mpfs_blocking_transaction(struct mpfs_sys_controller *mpfs_client, void *msg,
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  de5473936808 ("mbox: add polarfire soc system controller mailbox")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the mailbox tree

From: <Conor.Dooley@microchip.com>
Date: 2021-06-21 14:11:12

On 21/06/2021 06:57, Stephen Rothwell wrote:
Hi all,

After merging the mailbox tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from drivers/mailbox/mailbox-mpfs.c:19:
include/soc/microchip/mpfs.h:43:12: warning: 'mpfs_blocking_transaction' defined but not used [-Wunused-function]
    43 | static int mpfs_blocking_transaction(struct mpfs_sys_controller *mpfs_client, void *msg,
       |            ^~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

   de5473936808 ("mbox: add polarfire soc system controller mailbox")

-- Cheers, Stephen Rothwell
Hi,
That function is defined for services using the mailbox, and since 
currently none exist it is redundant. I will move it to another patch 
series that adds the services and resubmit this series.

Thanks,
Conor.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help