Re: linux-next: Fixes tag needs some work in the net-next tree
From: Vinod Koul <vkoul@kernel.org>
Date: 2019-02-21 05:34:17
Also in:
lkml, netdev
From: Vinod Koul <vkoul@kernel.org>
Date: 2019-02-21 05:34:17
Also in:
lkml, netdev
On 20-02-19, 20:59, Stefano Brivio wrote:
On Wed, 20 Feb 2019 11:02:01 -0800 (PST) David Miller [off-list ref] wrote:quoted
From: Jiri Pirko <jiri@resnulli.us> Date: Wed, 20 Feb 2019 09:36:11 +0100quoted
Would be good to have some robot checking "Fixes" sanity...I want to add a script to my trees that locally do it for me but the backlog for patch review for me is so huge that I never get to "fun" tasks like that....If it helps, this is what I use after being bitten once: #!/bin/sh [ ${#} -ne 2 ] && echo "Usage: %0 PATCH_FILE GIT_TREE" && exit 1 grep "^Fixes: " "${1}" | while read -r f; do sha="$(echo "${f}" | cut -d' ' -f2)" if [ -z "${sha}" ] || [ "${f}" != "$(git -C "${2}" show -s --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then echo "Bad tag: ${f}" && exit 1 fi done
Awesome thanks, I am adding this into my patch commit script and well as send script -- ~Vinod