Thread (1 message) 1 message, 1 author, 2019-02-13

Re: linux-next: Tree for Feb 12 (chrome/wilco_ec/)

From: Randy Dunlap <hidden>
Date: 2019-02-13 00:05:01
Also in: lkml

Possibly related (same subject, not in this thread)

On 2/12/19 3:49 PM, Nick Crews wrote:
quoted hunk
OK, here is the patch to fix this problem. We had the dependency backwards.

Should I re-send out the entire patch series to the LKML with this fix in it?


diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
index 462eb9dfa4f2..b69561050868 100644
--- a/drivers/platform/chrome/Kconfig
+++ b/drivers/platform/chrome/Kconfig
@@ -95,7 +95,7 @@ config CROS_EC_LPC
 
 config CROS_EC_LPC_MEC
        bool "ChromeOS Embedded Controller LPC Microchip EC (MEC) variant"
-       depends on CROS_EC_LPC || WILCO_EC
+       depends on CROS_EC_LPC
        default n
        help
          If you say Y here, a variant LPC protocol for the Microchip EC
diff --git a/drivers/platform/chrome/wilco_ec/Kconfig b/drivers/platform/chrome/wilco_ec/Kconfig
index d8e2cddb4712..6ea2d3f64ce5 100644
--- a/drivers/platform/chrome/wilco_ec/Kconfig
+++ b/drivers/platform/chrome/wilco_ec/Kconfig
@@ -1,6 +1,6 @@
 config WILCO_EC
        tristate "ChromeOS Wilco Embedded Controller"
-       depends on ACPI && X86
+       depends on ACPI && X86 && CROS_EC_LPC_MEC
        select CROS_EC_LPC_MEC
        help
          If you say Y here, you get support for talking to the ChromeOS

Hi Nick,

Your emails contain html and are not being archived by lore.kernel.org
or by marc.info.  Please fix that (no html) and resend the patch.

I don't know the answer to your question.  I would expect that whoever
merged the current drivers/platform/chrome/wilco_ec/ source files
could/would just take the new Kconfig patch and merge it also.


-- 
~Randy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help