Hi,

On Thursday 15 February 2018 06:19 AM, Stephen Rothwell wrote:

Hi Ulf,

After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_set_timing':
drivers/mmc/host/sdhci-omap.c:466:8: error: implicit declaration of function 'pinctrl_select_state'; did you mean 'inc_node_state'? [-Werror=implicit-function-declaration]
  ret = pinctrl_select_state(omap_host->pinctrl, pinctrl_state);
        ^~~~~~~~~~~~~~~~~~~~
        inc_node_state
drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_iodelay_pinctrl_state':
drivers/mmc/host/sdhci-omap.c:740:18: error: implicit declaration of function 'pinctrl_lookup_state'; did you mean 'inc_node_state'? [-Werror=implicit-function-declaration]
  pinctrl_state = pinctrl_lookup_state(omap_host->pinctrl, mode);
                  ^~~~~~~~~~~~~~~~~~~~
                  inc_node_state
drivers/mmc/host/sdhci-omap.c:740:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  pinctrl_state = pinctrl_lookup_state(omap_host->pinctrl, mode);
                ^
drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_config_iodelay_pinctrl_state':
drivers/mmc/host/sdhci-omap.c:769:23: error: implicit declaration of function 'devm_pinctrl_get'; did you mean 'devm_clk_get'? [-Werror=implicit-function-declaration]
  omap_host->pinctrl = devm_pinctrl_get(omap_host->dev);
                       ^~~~~~~~~~~~~~~~
                       devm_clk_get
drivers/mmc/host/sdhci-omap.c:769:21: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  omap_host->pinctrl = devm_pinctrl_get(omap_host->dev);
                     ^
drivers/mmc/host/sdhci-omap.c:775:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  state = pinctrl_lookup_state(omap_host->pinctrl, "default");
        ^

Caused by commit

  713190bb14aa ("mmc: sdhci_omap: Add support to set IODELAY values")

Forgot to include linux/pinctrl/consumer.h?

yeah, looks like it though I didn't observe this error with omap2plus_defconfig.

Ulf, can you drop "mmc: sdhci_omap: Add support to set IODELAY values" patch
from your next. I'll resend the patch after fixing it.

Thanks
Kishon