linux-next: build warning after merge of the tpmdd tree

2 messages, 2 authors, 2016-11-15 · open the first message on its own page

linux-next: build warning after merge of the tpmdd tree

From: Stephen Rothwell <hidden>
Date: 2016-11-15 01:01:13

Hi Jarkko,

After merging the tpmdd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/char/tpm/tpm_of.c: In function 'read_log_of':
drivers/char/tpm/tpm_of.c:37:8: warning: 'np' may be used uninitialized in this function [-Wmaybe-uninitialized]
  sizep = of_get_property(np, "linux,sml-size", NULL);
        ^

Introduced by commit

  4a45d9669ac1 ("tpm: replace of_find_node_by_name() with dev of_node property")

This commit is just wrong :-(

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the tpmdd tree

From: Jarkko Sakkinen <hidden>
Date: 2016-11-15 02:13:46

On Tue, Nov 15, 2016 at 12:01:07PM +1100, Stephen Rothwell wrote:
Hi Jarkko,

After merging the tpmdd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/char/tpm/tpm_of.c: In function 'read_log_of':
drivers/char/tpm/tpm_of.c:37:8: warning: 'np' may be used uninitialized in this function [-Wmaybe-uninitialized]
  sizep = of_get_property(np, "linux,sml-size", NULL);
        ^

Introduced by commit

  4a45d9669ac1 ("tpm: replace of_find_node_by_name() with dev of_node property")

This commit is just wrong :-(
It really is. I'll drop it from my tree.
-- 
Cheers,
Stephen Rothwell
/Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help