linux-next: build failure after merge of the akpm tree

From: Stephen Rothwell <hidden>
Date: 2012-09-21 06:08:51
Also in: lkml
Subsystem: exec & binfmt api, elf, filesystems (vfs and infrastructure), the rest · Maintainers: Kees Cook, Alexander Viro, Christian Brauner, Linus Torvalds

Hi Andrew,

After merging the akpm tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/binfmt_elf.c: In function 'fill_files_note':
fs/binfmt_elf.c:1419:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
fs/binfmt_elf.c:1419:7: warning: assignment makes pointer from integer without a cast [enabled by default]
fs/binfmt_elf.c:1437:5: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]

Caused by commit "coredump: extend core dump note section to contain file
names of mapped files".  Forgot to include vmalloc.h :-(

I added this patch for today:

From: Stephen Rothwell <redacted>
Date: Fri, 21 Sep 2012 16:06:18 +1000
Subject: [PATCH] coredump: using vmalloc requires the inclusion of vmalloc.h

Signed-off-by: Stephen Rothwell <redacted>
---
 fs/binfmt_elf.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index 0973943..5ac905f 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -32,6 +32,7 @@
 #include <linux/elf.h>
 #include <linux/utsname.h>
 #include <linux/coredump.h>
+#include <linux/vmalloc.h>
 #include <asm/uaccess.h>
 #include <asm/param.h>
 #include <asm/page.h>
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help