# Re: linux-next: Tree for Aug 30 (jbd2 + bug.h)

- From: Arnd Bergmann \<arnd@arndb.de\>
- Date: 2011-09-01 11:43:32 
- List: linux-next
- Page: https://ratatoskr.run/linux-next/2011/09/3759646
- Thread: https://ratatoskr.run/linux-ext4/2011/08/3759384/t.md

```text
On Wednesday 31 August 2011, Randy Dunlap wrote:
> On Tue, 30 Aug 2011 17:16:05 +1000 Stephen Rothwell wrote:
> 
> > Hi all,
> 
> [Sorry about the delay.  My build machine is being slow.
> If this is alread fixed, sorry about the noise.]
> 
> 
> When CONFIG_BUG is not enabled (I see this on x86_64):
> 
> fs/jbd2/transaction.c: In function 'jbd2_journal_dirty_metadata':
> fs/jbd2/transaction.c:1176: error: implicit declaration of function '__WARN'
> 
> 
> asm-generic/bug.h does not provide a version of __WARN() when
> CONFIG_BUG is not enabled...
> 

Hmm, my feeling is that we shouldn't do that either, and that jbd2 should
be changed. If we want a function that does what __WARN() does today, we
should probably make a conscious decision about what we want it to be called
and not have it start with "__".

	Arnd
```
