Re: linux-next: Tree for June 23 (net/can & i/o)
From: Stephen Rothwell <hidden>
Date: 2011-06-24 01:04:20
Also in:
lkml, netdev
Attachments
- (unnamed) [application/pgp-signature] 490 bytes
From: Stephen Rothwell <hidden>
Date: 2011-06-24 01:04:20
Also in:
lkml, netdev
Hi Mike, On Thu, 23 Jun 2011 16:38:56 -0400 Mike Frysinger [off-list ref] wrote:
not sure where this is coming from, but some Blackfin boards now fail with: drivers/net/can/bfin_can.c: In function 'bfin_can_start_xmit': drivers/net/can/bfin_can.c:247: error: implicit declaration of function 'writew' make[3]: *** [drivers/net/can/bfin_can.o] Error 1
yeah, caused by the removal of the inclusion of mm.h from netdevice.h (most probably).
at any rate, the usage of writew() in this driver is wrong, so i sent a patch to fix it. but since nothing in this file nor in my Blackfin tree changed, i wonder if whatever common code changed is going to break other stuff ...
It did indeed :-( ah, well, I guess that is what I am here for :-) -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/