Re: linux-next: scsi tree build failure
From: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: 2008-12-22 01:59:29
On Sun, 2008-12-21 at 14:30 +1100, Stephen Rothwell wrote:
Hi James, Robert, On Wed, 17 Dec 2008 23:20:49 +1100 Stephen Rothwell [off-list ref] wrote:quoted
On Mon, 15 Dec 2008 08:52:42 -0600 James Bottomley [off-list ref] wrote:quoted
On Tue, 2008-12-16 at 01:37 +1100, Stephen Rothwell wrote:quoted
Today's linux-next build (powerpc allyesconfig) failed like this:Heh, I really need to get this terrasoft system integrated into my buildsquoted
drivers/scsi/libfc/fc_fcp.c: In function 'fc_eh_host_reset': drivers/scsi/libfc/fc_fcp.c:1987: error: implicit declaration of function 'msleep' That file needs to include <linux/delay.h>.Thanks, that's exactly the problem. Robert, please reroll the patches with this fix in ... I'll just exchange the new patches for the ones in my tree.quoted
Introduced by commit 389571f347629d879f9044582bbbafb43e4fe00b ("[SCSI] libfc: A modular Fibre Channel library") from the scsi tree. I reverted that commit and commit 7aba33c5cfc7a9c104cc7469558c7849f373c3da ("[SCSI] fcoe: Fibre Channel over Ethernet") which depended on it.I have dropped the scsi tree until this is fixed up.I still haven't see a fix for this ...
OK, gave up waiting for an updated patch, so I fixed this myself in my tree. scsi-misc should be safe to go again. Thanks, James