# Re: \[PATCH 02/20\] pinctrl: amd: remove MODULE\_LICENSE in non-modules

- From: Linus Walleij \<hidden\>
- Date: 2023-03-07 13:11:40 
- List: linux-modules
- Page: https://ratatoskr.run/linux-modules/2023/03/2123282
- Thread: https://ratatoskr.run/linux-modules/2023/02/2115847/t.md

```text
On Tue, Feb 28, 2023 at 2:02 PM Nick Alcock [ref] wrote:

> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <redacted>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: <redacted>
> Cc: <redacted>
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
> Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> Cc: Linus Walleij <redacted>
> Cc: <redacted>

Can I just merge the 3 pinctrl patches to the pinctrl tree or are there
any dependencies?

Yours,
Linus Walleij
```
