# Re: \[PATCH 08/20\] remoteproc: remove MODULE\_LICENSE in non-modules

- From: Mukesh Ojha \<hidden\>
- Date: 2023-02-28 13:35:50 
- List: linux-modules
- Page: https://ratatoskr.run/linux-modules/2023/02/2115866
- Thread: https://ratatoskr.run/linux-modules/2023/02/2115847/t.md

```text


On 2/28/2023 6:32 PM, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <redacted>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: <redacted>
> Cc: <redacted>
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: <redacted>

Acked-by: Mukesh Ojha <redacted>

-Mukesh
> ---
>   drivers/remoteproc/remoteproc_core.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 1cd4815a6dd19..de1ace44cb57b 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -2765,5 +2765,4 @@ static void __exit remoteproc_exit(void)
>   }
>   module_exit(remoteproc_exit);
>   
> -MODULE_LICENSE("GPL v2");
>   MODULE_DESCRIPTION("Generic Remote Processor Framework");
```
