# Re: \[PATCH 15/27\] kbuild, cpufreq: remove MODULE\_LICENSE in non-modules

- From: Viresh Kumar \<viresh.kumar@linaro.org\>
- Date: 2023-02-23 04:22:15 
- List: linux-modules
- Page: https://ratatoskr.run/linux-modules/2023/02/2110748
- Thread: https://ratatoskr.run/linux-modules/2023/02/2109975/t.md

```text
On 22-02-23, 12:14, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <redacted>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: <redacted>
> Cc: <redacted>
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: <redacted>
> ---
>  drivers/cpufreq/freq_table.c | 1 -
>  1 file changed, 1 deletion(-)

Applied. Thanks.

-- 
viresh
```
