# Re: \[PATCH 12/24\] kbuild, soc: sunxi: sram: remove MODULE\_LICENSE in non-modules

- From: Jernej Škrabec \<jernej.skrabec@gmail.com\>
- Date: 2023-02-21 18:24:36 
- List: linux-modules
- Page: https://ratatoskr.run/linux-modules/2023/02/2109106
- Thread: https://ratatoskr.run/linux-modules/2023/02/2105639/t.md

```text
Dne petek, 17. februar 2023 ob 15:10:47 CET je Nick Alcock napisal(a):
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.
> 
> Signed-off-by: Nick Alcock <redacted>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: <redacted>
> Cc: <redacted>
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Chen-Yu Tsai <redacted>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Samuel Holland <samuel@sholland.org>
> Cc: <redacted>
> Cc: <redacted>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej




```