[PATCH] kmod: compiling with old sed version (!ERE support)

Subsystems: the rest

STALE3761d

2 messages, 2 authors, 2016-05-21 · open the first message on its own page

[PATCH] kmod: compiling with old sed version (!ERE support)

From: <hidden>
Date: 2016-05-02 14:39:08

From: Héctor Orón Martínez <redacted>

  Makefile.am uses `sed -E', which it is found on BSD sed; however a
  replacement on GNU sed would be `sed -r'. Both intend to use extended
  regular expressions (ERE). However I have a system that does not support
  those, in benefit for portability could you consider replacing ERE by BRE.

Signed-off-by: Héctor Orón Martínez <redacted>
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 2d9f2cf..8813475 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -107,7 +107,7 @@ install-exec-hook:
 	if test "$(libdir)" != "$(rootlibdir)"; then \
 		$(MKDIR_P) $(DESTDIR)$(rootlibdir) && \
 		so_img_name=$$(readlink $(DESTDIR)$(libdir)/libkmod.so) && \
-		so_img_rel_target_prefix=$$(echo $(libdir) | sed -E 's,(^/|)[^/][^/]*,..,g') && \
+		so_img_rel_target_prefix=$$(echo $(libdir) | sed 's,\(^/\|\)[^/][^/]*,..,g') && \
 		ln -sf $$so_img_rel_target_prefix$(rootlibdir)/$$so_img_name $(DESTDIR)$(libdir)/libkmod.so && \
 		mv $(DESTDIR)$(libdir)/libkmod.so.* $(DESTDIR)$(rootlibdir); \
 	fi
-- 
2.8.0.rc3

Re: [PATCH] kmod: compiling with old sed version (!ERE support)

From: Lucas De Marchi <hidden>
Date: 2016-05-21 18:09:02

On Mon, May 2, 2016 at 11:38 AM,  [off-list ref] wrote:
From: H=C3=A9ctor Or=C3=B3n Mart=C3=ADnez <redacted>

  Makefile.am uses `sed -E', which it is found on BSD sed; however a
  replacement on GNU sed would be `sed -r'. Both intend to use extended
  regular expressions (ERE). However I have a system that does not suppor=
t
  those, in benefit for portability could you consider replacing ERE by B=
RE.
Signed-off-by: H=C3=A9ctor Or=C3=B3n Mart=C3=ADnez <hector.oron@gmail.com=

---
Applied, thanks.

Lucas De Marchi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help