[PATCH] kbuild: do not check for ancient modutils tools

scripts/depmod.sh checks for the output of '-V' expecting that it has
module-init-tools in it. It's a hack to prevent users from using
modutils instead of module-init-tools, that only works with 2.4.x
kernels. This however prints an annoying warning for kmod tool, that is
currently replacing module-init-tools.

Rather than putting another check for kmod's version, just remove it
since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
do, let depmod fail in that case because they should know what they are
doing.

Signed-off-by: Lucas De Marchi <redacted>
---
 scripts/depmod.sh |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/scripts/depmod.sh b/scripts/depmod.sh
index a272356..2ae4817 100755
--- a/scripts/depmod.sh
+++ b/scripts/depmod.sh

@@ -9,12 +9,6 @@ fi
 DEPMOD=$1
 KERNELRELEASE=$2
 
-if ! "$DEPMOD" -V 2>/dev/null | grep -q module-init-tools; then
-	echo "Warning: you may need to install module-init-tools" >&2
-	echo "See http://www.codemonkey.org.uk/docs/post-halloween-2.6.txt" >&2
-	sleep 1
-fi
-
 if ! test -r System.map -a -x "$DEPMOD"; then
 	exit 0
 fi

-- 
1.7.8.3

On Tue, 2012-01-17 at 14:50 -0200, Lucas De Marchi wrote:

scripts/depmod.sh checks for the output of '-V' expecting that it has
module-init-tools in it. It's a hack to prevent users from using
modutils instead of module-init-tools, that only works with 2.4.x
kernels. This however prints an annoying warning for kmod tool, that is
currently replacing module-init-tools.

Rather than putting another check for kmod's version, just remove it
since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
do, let depmod fail in that case because they should know what they are
doing.

Signed-off-by: Lucas De Marchi <redacted>

Acked-by: WANG Cong <redacted>

Thanks.

On Wed, Jan 18, 2012 at 05:33, Cong Wang [off-list ref] wrote:

On Tue, 2012-01-17 at 14:50 -0200, Lucas De Marchi wrote:

quoted

scripts/depmod.sh checks for the output of '-V' expecting that it has
module-init-tools in it. It's a hack to prevent users from using
modutils instead of module-init-tools, that only works with 2.4.x
kernels. This however prints an annoying warning for kmod tool, that is
currently replacing module-init-tools.

Rather than putting another check for kmod's version, just remove it
since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
do, let depmod fail in that case because they should know what they are
doing.

Signed-off-by: Lucas De Marchi <redacted>

Acked-by: WANG Cong <redacted>

Michal, mind picking this up? The warning it produces with kmod is
really misleading, and the check seems unnecessary these days.

  Acked-By: Kay Sievers [off-list ref]

Thanks,
Kay

On Fri, Jan 20, 2012 at 05:40:58PM +0100, Kay Sievers wrote:

On Wed, Jan 18, 2012 at 05:33, Cong Wang [off-list ref] wrote:

quoted

On Tue, 2012-01-17 at 14:50 -0200, Lucas De Marchi wrote:

quoted

scripts/depmod.sh checks for the output of '-V' expecting that it has
module-init-tools in it. It's a hack to prevent users from using
modutils instead of module-init-tools, that only works with 2.4.x
kernels. This however prints an annoying warning for kmod tool, that is
currently replacing module-init-tools.

You could call kmod "module-init-tools 3.13 (compatible; kmod 3)" ;)

Just kidding.

quoted

quoted

Rather than putting another check for kmod's version, just remove it
since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
do, let depmod fail in that case because they should know what they are
doing.

Signed-off-by: Lucas De Marchi <redacted>

Acked-by: WANG Cong <redacted>

Michal, mind picking this up? The warning it produces with kmod is
really misleading, and the check seems unnecessary these days.

I applied it to kbuild.git#rc-fixes and will send it to Linus for 3.3.

Michal

On Mon, Jan 23, 2012 at 12:17 PM, Michal Marek [off-list ref] wrote:

On Fri, Jan 20, 2012 at 05:40:58PM +0100, Kay Sievers wrote:

quoted

On Wed, Jan 18, 2012 at 05:33, Cong Wang [off-list ref] wrote:

quoted

On Tue, 2012-01-17 at 14:50 -0200, Lucas De Marchi wrote:

quoted

scripts/depmod.sh checks for the output of '-V' expecting that it has
module-init-tools in it. It's a hack to prevent users from using
modutils instead of module-init-tools, that only works with 2.4.x
kernels. This however prints an annoying warning for kmod tool, that is
currently replacing module-init-tools.

You could call kmod "module-init-tools 3.13 (compatible; kmod 3)" ;)

Just kidding.

I even wrote a patch to fake kmod as module-init-tools 4.0. Not worth
applying though  :-)

quoted

quoted

quoted

Rather than putting another check for kmod's version, just remove it
since users of 2.4.x kernel are unlikely to upgrade to 3.x, and if they
do, let depmod fail in that case because they should know what they are
doing.

Signed-off-by: Lucas De Marchi <redacted>

Acked-by: WANG Cong <redacted>

Michal, mind picking this up? The warning it produces with kmod is
really misleading, and the check seems unnecessary these days.

I applied it to kbuild.git#rc-fixes and will send it to Linus for 3.3.

Thanks
Lucas De Marchi