[PATCH] mmc: dw_mmc: correct outdated comment for use_dma
Subsystems:
multimedia card (mmc), secure digital (sd) and sdio subsystem , synopsys designware mmc/sd/sdio driver , the rest
STALE3227d
2 messages,
2 authors,
2017-10-02 · open the first message on its own page
Since commit 3fc7eaef44db ("mmc: dw_mmc: Add external dma interface
support") use_dma no longer means only the data transfer mode, and
includes dma transmission channel. So make it more clear.
Signed-off-by: Ziyuan <redacted>
---
drivers/mmc/host/dw_mmc.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
index 34474ad..e3124f0 100644
--- a/drivers/mmc/host/dw_mmc.h
+++ b/drivers/mmc/host/dw_mmc.h @@ -74,7 +74,8 @@ struct dw_mci_dma_slave {
* @ stop_abort : The command currently prepared for stoping transfer .
* @ prev_blksz : The former transfer blksz record .
* @ timing : Record of current ios timing .
- * @ use_dma : Whether DMA channel is initialized or not .
+ * @ use_dma : Which DMA channel is in use for the current transfer , zero
+ * denotes PIO mode .
* @ using_dma : Whether DMA is in use for the current transfer .
* @ dma_64bit_address : Whether DMA supports 64 - bit address mode or not .
* @ sg_dma : Bus address of DMA buffer . --
2.7.4
On 30 August 2017 at 04:58, Ziyuan [off-list ref] wrote: Since commit 3fc7eaef44db ("mmc: dw_mmc: Add external dma interface
support") use_dma no longer means only the data transfer mode, and
includes dma transmission channel. So make it more clear.
Signed-off-by: Ziyuan <redacted>
Thanks, applied for next!
Kind regards
Uffe
quoted hunk ---
drivers/mmc/host/dw_mmc.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
index 34474ad..e3124f0 100644
--- a/drivers/mmc/host/dw_mmc.h
+++ b/drivers/mmc/host/dw_mmc.h @@ -74,7 +74,8 @@ struct dw_mci_dma_slave {
* @ stop_abort : The command currently prepared for stoping transfer .
* @ prev_blksz : The former transfer blksz record .
* @ timing : Record of current ios timing .
- * @ use_dma : Whether DMA channel is initialized or not .
+ * @ use_dma : Which DMA channel is in use for the current transfer , zero
+ * denotes PIO mode .
* @ using_dma : Whether DMA is in use for the current transfer .
* @ dma_64bit_address : Whether DMA supports 64 - bit address mode or not .
* @ sg_dma : Bus address of DMA buffer .
- - 2.7.4