Thread (14 messages) 14 messages, 2 authors, 2021-11-04

Re: [PATCH v3 4/6] folio: Add a function to get the host inode for a folio

From: Matthew Wilcox <willy@infradead.org>
Date: 2021-11-03 13:21:48
Also in: ceph-devel, linux-cifs, linux-fsdevel, linux-nfs, lkml

On Tue, Nov 02, 2021 at 08:30:46AM +0000, David Howells wrote:
Add a convenience function, folio_inode() that will get the host inode from
a folio's mapping.
I'm not opposed, but it only saves two characters, so I'm not entirely
sure it justifies its existance.  On the other hand, folio_inode() is
clear about what it does.
+ * For folios which are in the page cache, return the inode that is hosting
+ * this folio belongs to.
This looks like an editing mistake.  Either you meant
'return the inode that hosts this folio' or
'return the inode this folio belongs to'
(and i prefer the second).

With that grammo fixed,

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help