# Re: \[patch 142/192\] procfs: allow reading fdinfo with PTRACE\_MODE\_READ

- From: Christian Brauner \<hidden\>
- Date: 2021-07-02 14:54:16 
- List: linux-mm
- Page: https://ratatoskr.run/linux-mm/2021/07/6509617
- Thread: https://ratatoskr.run/linux-mm/2021/07/6509393/t/3.md

```text
On Wed, Jun 30, 2021 at 06:54:44PM -0700, Andrew Morton wrote:
> From: Kalesh Singh <redacted>
> Subject: procfs: allow reading fdinfo with PTRACE_MODE_READ
> 
> Android captures per-process system memory state when certain low memory
> events (e.g a foreground app kill) occur, to identify potential memory
> hoggers.  In order to measure how much memory a process actually consumes,
> it is necessary to include the DMA buffer sizes for that process in the
> memory accounting.  Since the handle to DMA buffers are raw FDs, it is
> important to be able to identify which processes have FD references to a
> DMA buffer.
> 
> Currently, DMA buffer FDs can be accounted using /proc/<pid>/fd/* and
> /proc/<pid>/fdinfo -- both are only readable by the process owner, as
> follows:
> 
>   1. Do a readlink on each FD.
>   2. If the target path begins with "/dmabuf", then the FD is a dmabuf FD.
>   3. stat the file to get the dmabuf inode number.
>   4. Read/ proc/<pid>/fdinfo/<fd>, to get the DMA buffer size.
> 
> Accessing other processes' fdinfo requires root privileges.  This limits
> the use of the interface to debugging environments and is not suitable for
> production builds.  Granting root privileges even to a system process
> increases the attack surface and is highly undesirable.
> 
> Since fdinfo doesn't permit reading process memory and manipulating
> process state, allow accessing fdinfo under PTRACE_MODE_READ_FSCRED.
> 
> Link: https://lkml.kernel.org/r/20210308170651.919148-1-kaleshsingh@google.com
> Signed-off-by: Kalesh Singh <redacted>
> Suggested-by: Jann Horn <jannh@google.com>
> Acked-by: Christian König <christian.koenig@amd.com>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Alexey Dobriyan <redacted>
> Cc: Alexey Gladkov <redacted>
> Cc: Andrei Vagin <redacted>
> Cc: Bernd Edlinger <redacted>
> Cc: Christian Brauner <redacted>
> Cc: Eric W. Biederman <redacted>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Hridya Valsaraju <redacted>
> Cc: James Morris <redacted>
> Cc: Jeff Vander Stoep <redacted>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Kees Cook <redacted>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Michel Lespinasse <redacted>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: Suren Baghdasaryan <surenb@google.com>
> Cc: Szabolcs Nagy <redacted>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---

Rather useful (also for CRIU and others).
Acked-by: Christian Brauner <redacted>

```
