# \[patch 167/192\] lib: memscan() fixlet

- From: Andrew Morton \<akpm@linux-foundation.org\>
- Date: 2021-07-01 01:56:04 
- List: linux-mm
- Page: https://ratatoskr.run/linux-mm/2021/07/6509559
- Thread: https://ratatoskr.run/linux-mm/2021/07/6509393/t/3.md

```text
From: Alexey Dobriyan <redacted>
Subject: lib: memscan() fixlet

Generic version doesn't trucate second argument to char.

Older brother memchr() does as do s390, sparc and i386 assembly versions.

Fortunately, no code passes c >= 256.

Link: https://lkml.kernel.org/r/YLv4cCf0t5UPdyK+@localhost.localdomain
Signed-off-by: Alexey Dobriyan <redacted>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 lib/string.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/lib/string.c~lib-memscan-fixlet
+++ a/lib/string.c
@@ -977,7 +977,7 @@ void *memscan(void *addr, int c, size_t
 	unsigned char *p = addr;
 
 	while (size) {
-		if (*p == c)
+		if (*p == (unsigned char)c)
 			return (void *)p;
 		p++;
 		size--;
_

```
