# Re: \[PATCH 1/3\] fs: unexport \_\_set\_page\_dirty

- From: Jan Kara \<jack@suse.cz\>
- Date: 2021-06-14 09:42:14 
- List: linux-mm
- Page: https://ratatoskr.run/linux-mm/2021/06/207657
- Thread: https://ratatoskr.run/linux-mm/2021/06/207647/t.md

```text
On Mon 14-06-21 08:15:10, Christoph Hellwig wrote:
> __set_page_dirty is only used by built-in code.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/buffer.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/buffer.c b/fs/buffer.c
> index ea48c01fb76b..3d18831c7ad8 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -611,7 +611,6 @@ void __set_page_dirty(struct page *page, struct address_space *mapping,
>  	}
>  	xa_unlock_irqrestore(&mapping->i_pages, flags);
>  }
> -EXPORT_SYMBOL_GPL(__set_page_dirty);
>  
>  /*
>   * Add a page to the dirty page list.
> -- 
> 2.30.2
> 
-- 
Jan Kara [ref]
SUSE Labs, CR

```
