[PATCH] mm: compaction: remove duplicate !list_empty(&sublist) check

Subsystems: memory management, memory management - page allocator, the rest

STALE1909d

2 messages, 2 authors, 2021-06-09 · open the first message on its own page

[PATCH] mm: compaction: remove duplicate !list_empty(&sublist) check

From: Liu Xiang <hidden>
Date: 2021-06-09 10:26:31

The list_splice_tail(&sublist, freelist) also do
!list_empty(&sublist) check, so remove the duplicate call.

Signed-off-by: Liu Xiang <redacted>
---
 mm/compaction.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index 84fde270a..5b1dc832f 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1297,8 +1297,7 @@ move_freelist_head(struct list_head *freelist, struct page *freepage)
 
 	if (!list_is_last(freelist, &freepage->lru)) {
 		list_cut_before(&sublist, freelist, &freepage->lru);
-		if (!list_empty(&sublist))
-			list_splice_tail(&sublist, freelist);
+		list_splice_tail(&sublist, freelist);
 	}
 }
 
@@ -1315,8 +1314,7 @@ move_freelist_tail(struct list_head *freelist, struct page *freepage)
 
 	if (!list_is_first(freelist, &freepage->lru)) {
 		list_cut_position(&sublist, freelist, &freepage->lru);
-		if (!list_empty(&sublist))
-			list_splice_tail(&sublist, freelist);
+		list_splice_tail(&sublist, freelist);
 	}
 }
 
-- 
2.17.1

Re: [PATCH] mm: compaction: remove duplicate !list_empty(&sublist) check

From: David Hildenbrand <hidden>
Date: 2021-06-09 11:27:53

On 09.06.21 11:54, Liu Xiang wrote:
quoted hunk
The list_splice_tail(&sublist, freelist) also do
!list_empty(&sublist) check, so remove the duplicate call.

Signed-off-by: Liu Xiang <redacted>
---
  mm/compaction.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index 84fde270a..5b1dc832f 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1297,8 +1297,7 @@ move_freelist_head(struct list_head *freelist, struct page *freepage)
  
  	if (!list_is_last(freelist, &freepage->lru)) {
  		list_cut_before(&sublist, freelist, &freepage->lru);
-		if (!list_empty(&sublist))
-			list_splice_tail(&sublist, freelist);
+		list_splice_tail(&sublist, freelist);
  	}
  }
  
@@ -1315,8 +1314,7 @@ move_freelist_tail(struct list_head *freelist, struct page *freepage)
  
  	if (!list_is_first(freelist, &freepage->lru)) {
  		list_cut_position(&sublist, freelist, &freepage->lru);
-		if (!list_empty(&sublist))
-			list_splice_tail(&sublist, freelist);
+		list_splice_tail(&sublist, freelist);
  	}
  }
  
Reviewed-by: David Hildenbrand <redacted>

-- 
Thanks,

David / dhildenb

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help