# Re: \[PATCH\] mm/nommu: unexport do\_munmap()

- From: Matthew Wilcox \<willy@infradead.org\>
- Date: 2021-06-05 14:36:19 
- List: linux-mm
- Page: https://ratatoskr.run/linux-mm/2021/06/1403554
- Thread: https://ratatoskr.run/linux-mm/2021/06/1403023/t.md

```text
On Fri, Jun 04, 2021 at 07:40:16PM +0000, Liam Howlett wrote:
> do_munmap() does not take the mmap_write_lock().  vm_munmap() should be
> used instead.

also, do_munmap was unexported for MMU builds back in 2012 by commit
17d1587f553d.

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

> Signed-off-by: Liam R. Howlett <redacted>
> ---
>  mm/nommu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/nommu.c b/mm/nommu.c
> index 0997ca38c2bd..3a93d4054810 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -1501,7 +1501,6 @@ int do_munmap(struct mm_struct *mm, unsigned long start, size_t len, struct list
>  	delete_vma(mm, vma);
>  	return 0;
>  }
> -EXPORT_SYMBOL(do_munmap);
>  
>  int vm_munmap(unsigned long addr, size_t len)
>  {
> -- 
> 2.30.2
> 

```
