# Re: \[PATCH v1 07/11\] mm/sparse-vmemmap: populate compound pagemaps

- From: Dan Williams \<hidden\>
- Date: 2021-05-10 19:20:13 
- List: linux-mm
- Page: https://ratatoskr.run/linux-mm/2021/05/6508129
- Thread: https://ratatoskr.run/linux-mm/2021/03/6507171/t.md

```text
On Thu, May 6, 2021 at 4:02 AM Joao Martins [ref] wrote:
[..]
> >> +static pte_t * __meminit vmemmap_lookup_address(unsigned long addr)
> >
> > I think this can be replaced with a call to follow_pte(&init_mm...).
> >
>
> Ah, of course! That would shorten things up too.

Now that I look closely, I notice that function disclaims being
suitable as a general purpose pte lookup utility. If it works for you,
great, but if not I think it's past time to create such a helper. I
know Ira is looking for one, and I contributed to the proliferation
when I added dev_pagemap_mapping_shift().

```