Thread (23 messages) 23 messages, 4 authors, 2021-04-28

Re: [PATCH v13 14/14] powerpc/64s/radix: Enable huge vmalloc mappings

From: Nicholas Piggin <npiggin@gmail.com>
Date: 2021-04-17 02:39:55
Also in: linux-arch, linuxppc-dev, lkml

Excerpts from Andrew Morton's message of April 16, 2021 4:55 am:
On Thu, 15 Apr 2021 12:23:55 +0200 Christophe Leroy [off-list ref] wrote:
quoted
quoted
+	 * is done. STRICT_MODULE_RWX may require extra work to support this
+	 * too.
+	 */
  
-	return __vmalloc_node_range(size, 1, MODULES_VADDR, MODULES_END, GFP_KERNEL,
-				    PAGE_KERNEL_EXEC, VM_FLUSH_RESET_PERMS, NUMA_NO_NODE,

I think you should add the following in <asm/pgtable.h>

#ifndef MODULES_VADDR
#define MODULES_VADDR VMALLOC_START
#define MODULES_END VMALLOC_END
#endif

And leave module_alloc() as is (just removing the enclosing #ifdef MODULES_VADDR and adding the 
VM_NO_HUGE_VMAP  flag)

This would minimise the conflits with the changes I did in powerpc/next reported by Stephen R.
I'll drop powerpc-64s-radix-enable-huge-vmalloc-mappings.patch for now,
make life simpler.
Yeah that's fine.
Nick, a redo on top of Christophe's changes in linux-next would be best
please.
Will do.

Thanks,
Nick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help