# Re: \[RFC PATCH 5/8\] mm: Pass 'address' to map to do\_set\_pte() and drop FAULT\_FLAG\_PREFAULT

- From: Will Deacon \<will@kernel.org\>
- Date: 2021-01-15 10:25:19 
- List: linux-mm
- Page: https://ratatoskr.run/linux-mm/2021/01/6235923
- Thread: https://ratatoskr.run/linux-mm/2021/01/6235067/t.md

```text
On Thu, Jan 14, 2021 at 10:17:22AM -0800, Linus Torvalds wrote:
> On Thu, Jan 14, 2021 at 10:01 AM Will Deacon [ref] wrote:
> >
> > Rather than modifying the 'address' field of the 'struct vm_fault_info'
> > passed to do_set_pte(), leave that to identify the real faulting address
> > and pass in the virtual address to be mapped by the new pte as a
> > separate argument.
> 
> Ack.
> 
> In fact - apart from the question I had about the 'info' sub-structure
> - ack on the whole series. But this one struck me particularly as
> "that's simpler and clearer" even if that finish_fault() case is now
> not as pretty (but with an unnamed structure it would be slightly
> simpler, at least).

Thanks. I'll post another spin next week to avoid the named structure, but
if you (or anybody else) get a chance to glance over some of the other
things I mentioned in the cover letter beforehand that would be really
great.

Cheers,

Will

```
