[PATCH] mm: remove mmu_notifier_get

Subsystems: memory management - core, the rest

STALE2210d

3 messages, 3 authors, 2020-09-16 · open the first message on its own page

[PATCH] mm: remove mmu_notifier_get

From: Christoph Hellwig <hch@lst.de>
Date: 2020-09-16 11:29:45 

Remove the unused mmu_notifier_get inline function.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/mmu_notifier.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
index b8200782dedeb9..acd1cc41f25d81 100644
--- a/include/linux/mmu_notifier.h
+++ b/include/linux/mmu_notifier.h
@@ -279,16 +279,6 @@ static inline int mm_has_notifiers(struct mm_struct *mm)
 
 struct mmu_notifier *mmu_notifier_get_locked(const struct mmu_notifier_ops *ops,
 					     struct mm_struct *mm);
-static inline struct mmu_notifier *
-mmu_notifier_get(const struct mmu_notifier_ops *ops, struct mm_struct *mm)
-{
-	struct mmu_notifier *ret;
-
-	mmap_write_lock(mm);
-	ret = mmu_notifier_get_locked(ops, mm);
-	mmap_write_unlock(mm);
-	return ret;
-}
 void mmu_notifier_put(struct mmu_notifier *subscription);
 void mmu_notifier_synchronize(void);
 
-- 
2.28.0

Re: [PATCH] mm: remove mmu_notifier_get

From: David Hildenbrand <hidden>
Date: 2020-09-16 12:33:28 

On 16.09.20 13:27, Christoph Hellwig wrote:
quoted hunk
Remove the unused mmu_notifier_get inline function.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/mmu_notifier.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
index b8200782dedeb9..acd1cc41f25d81 100644
--- a/include/linux/mmu_notifier.h
+++ b/include/linux/mmu_notifier.h
@@ -279,16 +279,6 @@ static inline int mm_has_notifiers(struct mm_struct *mm)
 
 struct mmu_notifier *mmu_notifier_get_locked(const struct mmu_notifier_ops *ops,
 					     struct mm_struct *mm);
-static inline struct mmu_notifier *
-mmu_notifier_get(const struct mmu_notifier_ops *ops, struct mm_struct *mm)
-{
-	struct mmu_notifier *ret;
-
-	mmap_write_lock(mm);
-	ret = mmu_notifier_get_locked(ops, mm);
-	mmap_write_unlock(mm);
-	return ret;
-}
 void mmu_notifier_put(struct mmu_notifier *subscription);
 void mmu_notifier_synchronize(void);
The doc of mmu_notifier_get_locked() has a reference to this function.

"Each call to mmu_notifier_get() must be paired with a call to
mmu_notifier_put()." - that should have been mmu_notifier_get_locked(),
maybe fix that up right away.

-- 
Thanks,

David / dhildenb

Re: [PATCH] mm: remove mmu_notifier_get

From: Jason Gunthorpe <jgg@ziepe.ca>
Date: 2020-09-16 15:53:47 

On Wed, Sep 16, 2020 at 01:27:24PM +0200, Christoph Hellwig wrote:
quoted hunk
Remove the unused mmu_notifier_get inline function.

Signed-off-by: Christoph Hellwig <hch@lst.de>
 include/linux/mmu_notifier.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
index b8200782dedeb9..acd1cc41f25d81 100644
+++ b/include/linux/mmu_notifier.h
@@ -279,16 +279,6 @@ static inline int mm_has_notifiers(struct mm_struct *mm)
 
 struct mmu_notifier *mmu_notifier_get_locked(const struct mmu_notifier_ops *ops,
 					     struct mm_struct *mm);
-static inline struct mmu_notifier *
-mmu_notifier_get(const struct mmu_notifier_ops *ops, struct mm_struct *mm)
-{
-	struct mmu_notifier *ret;
-
-	mmap_write_lock(mm);
-	ret = mmu_notifier_get_locked(ops, mm);
-	mmap_write_unlock(mm);
-	return ret;
-}
 void mmu_notifier_put(struct mmu_notifier *subscription);
 void mmu_notifier_synchronize(void);
Looks like I missed this from 

Fixes: f25a546e6529 ("RDMA/odp: Use mmu_interval_notifier_insert()")

Though, I have a vauge recollection that some SVA IOMMU patches posted
wanted to use this too? They can bring it back if it makes sense

Looks like David is right about the comment, but aside from that:

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

v2 should go through Andrew's tree

Thanks,
Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help