The class index and fullness group are not encoded in
(first)page->mapping any more, after commit 3783689a1aa8 ("zsmalloc:
introduce zspage structure"). Instead, they are store in struct zspage.
Cc: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <redacted>
Cc: Nitin Gupta <redacted>
Cc: Hanjun Guo <guohanjun@huawei.com>
Signed-off-by: Yisheng Xie <redacted>
---
mm/zsmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 9cc3c0b..4b87225 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -270,7 +270,7 @@ struct zs_pool {
/*
* A zspage's class index and fullness group
- * are encoded in its (first)page->mapping
+ * are stored in struct zspage.
*/
#define FULLNESS_BITS 2
#define CLASS_BITS 8--
1.7.12.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
On (02/09/17 11:23), Yisheng Xie wrote:
The class index and fullness group are not encoded in
(first)page->mapping any more, after commit 3783689a1aa8 ("zsmalloc:
introduce zspage structure"). Instead, they are store in struct zspage.
Cc: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <redacted>
Cc: Nitin Gupta <redacted>
Cc: Hanjun Guo <guohanjun@huawei.com>
Signed-off-by: Yisheng Xie <redacted>
no objections from my side.
Reviewed-by: Sergey Senozhatsky <redacted>
a side note - may be we don't need this comment at all.
the code looks like this:
/*
* A zspage's class index and fullness group
* are stored in struct zspage.
*/
#define FULLNESS_BITS 2
#define CLASS_BITS 8
#define ISOLATED_BITS 3
#define MAGIC_VAL_BITS 8
struct zspage {
struct {
unsigned int fullness:FULLNESS_BITS;
unsigned int class:CLASS_BITS;
unsigned int isolated:ISOLATED_BITS;
unsigned int magic:MAGIC_VAL_BITS;
};
unsigned int inuse;
unsigned int freeobj;
struct page *first_page;
struct list_head list; /* fullness list */
#ifdef CONFIG_COMPACTION
rwlock_t lock;
#endif
};
so, basically, the comment just "repeats" the next 5 lines.
but, like I said, that's just a side note.
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>