Hi all:
I readed a raid5,which size 30T.OS is RHEL6 32bit.
I reaed the raid5(as a whole,not parted) and found read address which not i wanted.
So I tested the newest kernel code,the problem is still.
I review the code, in function do_generic_file_read()
index = *ppos >> PAGE_CACHE_SHIFT;
index is u32.and *ppos is long long.
So when *ppos is larger than 0xFFFF FFFF * PAGE_CACHE_SHIFT(16T Byte),then the index is error.
I wonder this .In 32bit os ,block devices size do not large then 16T,in other words, if block devices larger than 16T,must parted.
Thanks all.
--------------
majianpeng
2012-05-24
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
On Thu, 24 May 2012, majianpeng wrote:
Hi all:
I readed a raid5,which size 30T.OS is RHEL6 32bit.
I reaed the raid5(as a whole,not parted) and found read address which not i wanted.
So I tested the newest kernel code,the problem is still.
I review the code, in function do_generic_file_read()
index = *ppos >> PAGE_CACHE_SHIFT;
index is u32.and *ppos is long long.
So when *ppos is larger than 0xFFFF FFFF * PAGE_CACHE_SHIFT(16T Byte),then the index is error.
I wonder this .In 32bit os ,block devices size do not large then 16T,in other words, if block devices larger than 16T,must parted.
I am not surprised that the page cache limitation prevents you from
reading the whole device with a 32-bit kernel. See MAX_LFS_FILESIZE in
include/linux/fs.h. Our answer to that is just to use a 64-bit kernel.
#if BITS_PER_LONG==32
#define MAX_LFS_FILESIZE (((u64)PAGE_CACHE_SIZE << (BITS_PER_LONG-1))-1)
#elif BITS_PER_LONG==64
#define MAX_LFS_FILESIZE 0x7fffffffffffffffUL
#endif
But I am a little surprised that you get as far as 16TiB (with 4k page):
I would have expected you to be stopped just before 8TiB (although I
suspect that the limitation to 8TiB rather than 16TiB is unnecessary).
And if I understand you correctly, read() or pread() gave you no error
at those large offsets, but supplied data from the low offset instead?
That does surprise me - have we missed a check there?
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
U29ycnkgZm9yIGxhdGUgdG8gcmVwbHkuSSByZXZpZXdlZCB0aGUgY29kZSBhZ2FpbiBhbmQgZm91bmQgc29tZSBwcm9ibGVhbS4NCkkgY3JlYXRlZCBhIHNvZnQtcmFpZCBhbmQgdGhlIHNpemUgd2FzIGxhcmdlciB0aGFuIDE2VC4NClRoZSBvcyBpcyB1YnVudHUgMTIuMDQgMzJiaXQgeDg2Lg0KVGhlIHVkZXYgY3JlYXRlIHRoZSBibG9jayBub2RlIGlzIC9kZXYgZGlyKGFzIHRtcGZzKS4NCkFuZCBJIHJlYWRlZCB0aGUgdG1wZnMgY29kZSA6DQppbiBtbS9zaG1lbS5jOnNobWVtX2ZpbGxfc3VwZXIoKQ0KPnNiLT5zX21heGJ5dGVzID0gTUFYX0xGU19GSUxFU0laRTsNCkluIG15IGNvbXB1dGVyLCBNQVhfTEZTX0ZJTEVTWkUgaXMgZXF1YWwgOFQgLTEuDQpCdXQgdGhlIHJlYWQgY29kZToNCmdlbmVyaWNfZmlsZV9haW9fcmVhZC0tPmRvX2dlbmVyaWNfZmlsZV9yZWFkW25vdCB1c2UgZGlyZWN0IGZsYWcNCkluIGZ1bmN0aW9uOmRvX2dlbmVyaWNfZmlsZV9yZWFkKCk6DQo+aW5kZXggPSAqcHBvcyA+PiBQQUdFX0NBQ0hFX1NISUZUOw0KaW5kZXggaXMgdGhlIHR5cGUgb2YgcGdvZmZfdC4NClNvIGlmICAqcHBvcyBpcyBsYXJnZXIgdGhhbiAxNlQsIHRoZSBpbmRleCBpcyBvdmVyZmxvdy5BcyB5b3Ugc2FpZCwgaXQgd2lsbCByZWFkIGxvdyBwb3NpdGlvbiBkYXRhLg0KDQpCdXQgSSB0ZXN0ZWQgdGhlIHdyaXRlIG9wZXJhdGlvbjoNCmJsa2Rldl9haW9fd3JpdGUtPl9fZ2VuZXJpY19maWxlX2Fpb193cml0ZS4NCkluIGZ1bmN0aW9uOl9fZ2VuZXJpY19maWxlX2Fpb193cml0ZSgpDQpJdCB3aWxsIGNoZWNrIGJ5IGZ1bmN0aW9uOmdlbmVyaWNfd3JpdGVfY2hlY2tzKCkNCkJ1dCBJbiBmdW5jdGlvbg0KPmlmIChsaWtlbHkoIWlzYmxrKSkgew0KPgkJaWYgKHVubGlrZWx5KCpwb3MgPj0gaW5vZGUtPmlfc2ItPnNfbWF4Ynl0ZXMpKSB7DQo+CQkJaWYgKCpjb3VudCB8fCAqcG9zID4gaW5vZGUtPmlfc2ItPnNfbWF4Ynl0ZXMpIHsNCj4JCQkJcmV0dXJuIC1FRkJJRzsNCj4JCQl9DQo+CQkJLyogemVyby1sZW5ndGggd3JpdGVzIGF0IC0+c19tYXhieXRlcyBhcmUgT0sgKi8NCj4JCX0NCg0KPgkJaWYgKHVubGlrZWx5KCpwb3MgKyAqY291bnQgPiBpbm9kZS0+aV9zYi0+c19tYXhieXRlcykpDQo+CQkJKmNvdW50ID0gaW5vZGUtPmlfc2ItPnNfbWF4Ynl0ZXMgLSAqcG9zOw0KPgl9IGVsc2Ugew0KPiNpZmRlZiBDT05GSUdfQkxPQ0sNCj4JCWxvZmZfdCBpc2l6ZTsNCj4JCWlmIChiZGV2X3JlYWRfb25seShJX0JERVYoaW5vZGUpKSkNCj4JCQlyZXR1cm4gLUVQRVJNOw0KPgkJaXNpemUgPSBpX3NpemVfcmVhZChpbm9kZSk7DQo+CQlpZiAoKnBvcyA+PSBpc2l6ZSkgew0KPgkJCWlmICgqY291bnQgfHwgKnBvcyA+IGlzaXplKQ0KPgkJCQlyZXR1cm4gLUVOT1NQQzsNCj4JCX0NCg0KPgkJaWYgKCpwb3MgKyAqY291bnQgPiBpc2l6ZSkNCj4JCQkqY291bnQgPSBpc2l6ZSAtICpwb3M7DQo+I2Vsc2UNCj4JCXJldHVybiAtRVBFUk07DQo+I2VuZGlmDQpBbHRob3VnaCBpdCBjaGVjayAoc19tYXhieXRlcylNQVhfTEZTX0ZJTEVTSVpFLkJ1dCBpcyBmaWxlIGlzIGJsb2NrIGRldmljZSxpdCBkaWQgbm90IGNoZWNrLGl0IG9ubHkgY2hlY2sgdGhlIHJlYWwgc2l6ZS4NCkJ1dCB0aGVyZSBpcyBhbHNvIGEgYnVnLkJlY2F1c2UgaWYgYmxvY2sgc2l6ZSA+IDE2VCx0aGVyZSB3YXMgbm90IGVycm9yIGFuZCBleGVjZWQgY29udGludWUuDQpXaGVuIGV4ZWMgZ2VuZXJpY19maWxlX2J1ZmZlcmVkX3dyaXRlKClbbm8gb2RyaWVjdCBhY3Rpb25dIC0tLT5nZW5lcmljX3BlcmZvcm1fd3JpdGUtLT53cml0ZV9iZWdpbltibGtkZXZfd3JpdGVfYmVnaW5dDQotLS0+YmxvY2tfd3JpdGVfYmVnaW4NCkluIGZ1bmN0aW9uOmJsb2NrX3dyaXRlX2JlZ2luKCkNCj5wZ29mZl90IGluZGV4ID0gcG9zID4+IFBBR0VfQ0FDSEVfU0hJRlQ7DQppbmRleCB3aWxsIG92ZXJmbG93Lg0KDQpJIG9uY2UgdGhvdWdodCB0byBwYXRjaCB0aG9zZSBidWcoSSBtYXkgYmUgd2VsbC1rbm93biAsaGFoYSkuQnV0IEkgY2FuJ3QsYXMgaXMgZ2VuZXJpY193cml0ZV9jaGVja3MoKToNCj4vKg0KPgkgKiBBcmUgd2UgYWJvdXQgdG8gZXhjZWVkIHRoZSBmcyBibG9jayBsaW1pdCA/DQo+CSAqDQo+CSAqIElmIHdlIGhhdmUgd3JpdHRlbiBkYXRhIGl0IGJlY29tZXMgYSBzaG9ydCB3cml0ZS4gIElmIHdlIGhhdmUNCj4JICogZXhjZWVkZWQgd2l0aG91dCB3cml0aW5nIGRhdGEgd2Ugc2VuZCBhIHNpZ25hbCBhbmQgcmV0dXJuIEVGQklHLg0KPgkgKiBMaW51cyBmcmVzdHJpY3QgaWRlYSB3aWxsIGNsZWFuIHRoZXNlIHVwIG5pY2VseS4uDQo+CSAqLw0KPglpZiAobGlrZWx5KCFpc2JsaykpIHsNCmhvdyB0byBkZWFsIHdpdGggYmxvY2s/IEFzIGEgcmVndWxhciBmaWxlIG9yIG5vdD8NCgkJCQkJCQ0KDQoNCg0KLS0tLS0tLS0tLS0tLS0tLS0tCQkJCSANCm1hamlhbnBlbmcNCjIwMTItMDUtMjgNCg0KLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0Kt6K8/sjLo7pIdWdoIERpY2tpbnMNCreiy83I1cbao7oyMDEyLTA1LTI3IDA1OjI0OjEzDQrK1bz+yMujum1hamlhbnBlbmcNCrOty82jukFsIFZpcm87IEFuZHJldyBNb3J0b247IGxpbnV4LW1tOyBsaW51eC1mc2RldmVsDQrW98zio7pSZTogdGhlIG1heCBzaXplIG9mIGJsb2NrIGRldmljZSBvbiAzMmJpdCBvcyx3aGVuIHVzaW5nZG9fZ2VuZXJpY19maWxlX3JlYWQoKSBwcm9jZWVkLg0KDQpPbiBUaHUsIDI0IE1heSAyMDEyLCBtYWppYW5wZW5nIHdyb3RlOg0KPiAgIEhpIGFsbDoNCj4gCQlJIHJlYWRlZCBhIHJhaWQ1LHdoaWNoIHNpemUgMzBULk9TIGlzIFJIRUw2IDMyYml0Lg0KPiAJICAgIEkgcmVhZWQgdGhlIHJhaWQ1KGFzIGEgd2hvbGUsbm90IHBhcnRlZCkgYW5kIGZvdW5kIHJlYWQgYWRkcmVzcyB3aGljaCBub3QgaSB3YW50ZWQuDQo+IAkJU28gSSB0ZXN0ZWQgdGhlIG5ld2VzdCBrZXJuZWwgY29kZSx0aGUgcHJvYmxlbSBpcyBzdGlsbC4NCj4gCQlJIHJldmlldyB0aGUgY29kZSwgaW4gZnVuY3Rpb24gZG9fZ2VuZXJpY19maWxlX3JlYWQoKQ0KPiANCj4gCQlpbmRleCA9ICpwcG9zID4+IFBBR0VfQ0FDSEVfU0hJRlQ7DQo+IAkJaW5kZXggaXMgdTMyLmFuZCAqcHBvcyBpcyBsb25nIGxvbmcuDQo+IAkJU28gd2hlbiAqcHBvcyBpcyBsYXJnZXIgdGhhbiAweEZGRkYgRkZGRiAqICBQQUdFX0NBQ0hFX1NISUZUKDE2VCBCeXRlKSx0aGVuIHRoZSBpbmRleCBpcyBlcnJvci4NCj4gDQo+IAkJSSB3b25kZXIgdGhpcyAuSW4gMzJiaXQgb3MgLGJsb2NrIGRldmljZXMgc2l6ZSBkbyBub3QgbGFyZ2UgdGhlbiAxNlQsaW4gb3RoZXIgd29yZHMsIGlmIGJsb2NrIGRldmljZXMgbGFyZ2VyIHRoYW4gMTZULG11c3QgcGFydGVkLg0KDQpJIGFtIG5vdCBzdXJwcmlzZWQgdGhhdCB0aGUgcGFnZSBjYWNoZSBsaW1pdGF0aW9uIHByZXZlbnRzIHlvdSBmcm9tDQpyZWFkaW5nIHRoZSB3aG9sZSBkZXZpY2Ugd2l0aCBhIDMyLWJpdCBrZXJuZWwuICBTZWUgTUFYX0xGU19GSUxFU0laRSBpbg0KaW5jbHVkZS9saW51eC9mcy5oLiAgT3VyIGFuc3dlciB0byB0aGF0IGlzIGp1c3QgdG8gdXNlIGEgNjQtYml0IGtlcm5lbC4NCg0KI2lmIEJJVFNfUEVSX0xPTkc9PTMyDQojZGVmaW5lIE1BWF9MRlNfRklMRVNJWkUgKCgodTY0KVBBR0VfQ0FDSEVfU0laRSA8PCAoQklUU19QRVJfTE9ORy0xKSktMSkgDQojZWxpZiBCSVRTX1BFUl9MT05HPT02NA0KI2RlZmluZSBNQVhfTEZTX0ZJTEVTSVpFIDB4N2ZmZmZmZmZmZmZmZmZmZlVMDQojZW5kaWYNCg0KQnV0IEkgYW0gYSBsaXR0bGUgc3VycHJpc2VkIHRoYXQgeW91IGdldCBhcyBmYXIgYXMgMTZUaUIgKHdpdGggNGsgcGFnZSk6DQpJIHdvdWxkIGhhdmUgZXhwZWN0ZWQgeW91IHRvIGJlIHN0b3BwZWQganVzdCBiZWZvcmUgOFRpQiAoYWx0aG91Z2ggSQ0Kc3VzcGVjdCB0aGF0IHRoZSBsaW1pdGF0aW9uIHRvIDhUaUIgcmF0aGVyIHRoYW4gMTZUaUIgaXMgdW5uZWNlc3NhcnkpLg0KDQpBbmQgaWYgSSB1bmRlcnN0YW5kIHlvdSBjb3JyZWN0bHksIHJlYWQoKSBvciBwcmVhZCgpIGdhdmUgeW91IG5vIGVycm9yDQphdCB0aG9zZSBsYXJnZSBvZmZzZXRzLCBidXQgc3VwcGxpZWQgZGF0YSBmcm9tIHRoZSBsb3cgb2Zmc2V0IGluc3RlYWQ/DQoNClRoYXQgZG9lcyBzdXJwcmlzZSBtZSAtIGhhdmUgd2UgbWlzc2VkIGEgY2hlY2sgdGhlcmU/DQoNCkh1Z2gNCg==--To unsubscribe, send a message with 'unsubscribe linux-mm' inthe body to majordomo@kvack.org. For more info on Linux MM,see: http://www.linux-mm.org/ .Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>