Re: VM Regress 0.5 - Compile error with CONFIG_HIGHMEM

From: Christoph Hellwig <hch@infradead.org>
Date: 2002-08-17 12:18:01

On Sat, Aug 17, 2002 at 12:09:20PM +0100, Mel wrote:

quoted hunk

On Thu, 15 Aug 2002, Mel wrote:

quoted

Project page: http://www.csn.ul.ie/~mel/projects/vmregress/
Download:     http://www.csn.ul.ie/~mel/projects/vmregress/vmregress-0.5.tar.gz

0.5 won't compile with CONFIG_HIGHMEM set. Apply the following trivial
patch and it will compile at least. VM Regress has not been tested with
CONFIG_HIGHMEM set at all but there is no reason for it to fail because no
presumptions has been made about the number of nodes or zones in the
machine

--- vmregress-0.5/src/sense/kvirtual.c	Tue Aug 13 22:43:48 2002
+++ vmregress-0.5-highmem/src/sense/kvirtual.c	Sat Aug 17 12:03:02 2002

@@ -29,6 +29,11 @@
 #include <linux/mm.h>
 #include <linux/sched.h>

+#ifdef CONFIG_HIGHMEM
+#include <linux/highmem.h>
+#include <asm/highmem.h>
+#endif

Shouldn't an undonditional #include <linux/highmem.h> do it much cleaner?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

Re: VM Regress 0.5 - Compile error with CONFIG_HIGHMEM

From: Mel <hidden>
Date: 2002-08-17 23:57:19

On Sat, 17 Aug 2002, Christoph Hellwig wrote:

Shouldn't an undonditional #include <linux/highmem.h> do it much cleaner?

I imagine so, but I had a bus to catch and didn't have time to verify if
they were files that should be unconditionally included. As it will be
Monday before I'm working again, I choose the safe option

-- 
Mel Gorman
MSc Student, University of Limerick
http://www.csn.ul.ie/~mel

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help