# Re: \[PATCH 05/20\] signal/mips: Update (\_save\|\_restore)\_fp\_context to fail with -EFAULT

- From: Eric W. Biederman \<hidden\>
- Date: 2021-10-25 20:55:42 
- List: linux-mips
- Page: https://ratatoskr.run/linux-mips/2021/10/1553582
- Thread: https://ratatoskr.run/linux-arch/2021/10/1553582/t.md

```text
"Maciej W. Rozycki" [ref] writes:

> On Wed, 20 Oct 2021, Eric W. Biederman wrote:
>
>> When an instruction to save or restore a register from the stack fails
>> in _save_fp_context or _restore_fp_context return with -EFAULT.  This
>> change was made to r2300_fpu.S[1] but it looks like it got lost with
>> the introduction of EX2[2].  This is also what the other implementation
>> of _save_fp_context and _restore_fp_context in r4k_fpu.S does, and
>> what is needed for the callers to be able to handle the error.
>
>  Umm, right, good catch, thanks!  I think this ought to be backported.
>
> Acked-by: Maciej W. Rozycki <macro@orcam.me.uk>
>

I will add a CC stable.  So it can be backported after it is merged.

Eric
```