# Re: \[PATCH v2 01/12\] arch: Export cpu\_logical\_map to modules

- From: Christoph Hellwig \<hch@infradead.org\>
- Date: 2021-09-28 05:09:54 
- List: linux-mips
- Page: https://ratatoskr.run/linux-mips/2021/09/1523913
- Thread: https://ratatoskr.run/linux-arm-kernel/2021/09/1523821/t.md

```text
On Mon, Sep 27, 2021 at 07:27:04PM -0700, Florian Fainelli wrote:
> In order to allow drivers/irqchip/irq-bcm7038-l1.c to be built as a
> module and usable in GKI, export cpu_logical_map or __cpu_logical_map
> towards the modules. This follows what MIPS has been doing since
> 2dc2ae344e0e ("MIPS: Export __cpu_number_map and __cpu_logical_map.")

This seems like a pretty bad idea.  For one you should export an
accessor instead of the data structure.  And this probably should be an
EXPORT_SYMBOL_GPL.
```