# Re: \[PATCH v4 12/15\] pci: Mark MSI data shared

- From: Christoph Hellwig \<hch@infradead.org\>
- Date: 2021-08-13 08:11:58 
- List: linux-mips
- Page: https://ratatoskr.run/linux-mips/2021/08/1476799
- Thread: https://ratatoskr.run/linux-pci/2021/08/1468282/t.md

```text
On Wed, Aug 04, 2021 at 05:52:15PM -0700, Kuppuswamy Sathyanarayanan wrote:
>  
> -	return ioremap(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);
> +	return ioremap_shared(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);

Please add a comment here.  I also find the amount of ioremap_* variants
rather frustrating.  Maybe it it is time for a ioremap_flags which
replaces the too-lowlevel pgprot_t of the ioremap_prot provided by some
architectures with a more highlevel flags arguments that could also
provide an accessible to the hypervisor flag.
```