# Re: \[PATCH v1 01/16\] dma-mapping: Allow map\_sg() ops to return negative error codes

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2021-07-16 06:29:34 
- List: linux-mips
- Page: https://ratatoskr.run/linux-mips/2021/07/1447211
- Thread: https://ratatoskr.run/linux-alpha/2021/07/1445836/t.md

```text
On Thu, Jul 15, 2021 at 10:45:29AM -0600, Logan Gunthorpe wrote:
> +	 * dma_map_sgtable() will return the error code returned and convert
> +	 * a zero return (for legacy implementations) into -EINVAL.
> +	 *
> +	 * dma_map_sg() will always return zero on any negative or zero
> +	 * return to satisfy its own calling convention.
>  	 */

I don't think this belongs here.

> +EXPORT_SYMBOL(dma_map_sgtable);

EXPORT_SYMBOL_GPL, please.
```