Re: [PATCH v2 1/6] pinctrl: Ingenic: Add missing pins to the JZ4770 MAC MII group.
From: Paul Cercueil <paul@crapouillou.net>
Date: 2021-03-12 13:06:18
Also in:
linux-devicetree, linux-gpio, lkml
Hi, Le jeu. 11 mars 2021 à 23:21, 周琰杰 (Zhou Yanjie) [off-list ref] a écrit :
The MII group of JZ4770's MAC should have 7 pins, add missing pins to the MII group. Signed-off-by: 周琰杰 (Zhou Yanjie) <redacted>
No Fixes: tag? And if the bug wasn't introduced in 5.12-rc1 you'll need to Cc linux-stable as well.
quoted hunk ↗ jump to hunk
--- Notes: v2: New patch. drivers/pinctrl/pinctrl-ingenic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/pinctrl/pinctrl-ingenic.cb/drivers/pinctrl/pinctrl-ingenic.c index f274612..05dfa0a 100644--- a/drivers/pinctrl/pinctrl-ingenic.c +++ b/drivers/pinctrl/pinctrl-ingenic.c@@ -667,7 +667,9 @@ static int jz4770_pwm_pwm7_pins[] = { 0x6b, }; static int jz4770_mac_rmii_pins[] = { 0xa9, 0xab, 0xaa, 0xac, 0xa5, 0xa4, 0xad, 0xae, 0xa6, 0xa8, }; -static int jz4770_mac_mii_pins[] = { 0xa7, 0xaf, }; +static int jz4770_mac_mii_pins[] = { + 0x7b, 0x7a, 0x7d, 0x7c, 0xa7, 0x24, 0xaf,
Maybe list them in order? And are you sure that's the whole list? The PM (section 12.2 in jz4770_pm_part3.pdf) lists more pins. Cheers, -Paul
+};
static const struct group_desc jz4770_groups[] = {
INGENIC_PIN_GROUP("uart0-data", jz4770_uart0_data, 0),
--
2.7.4