Re: [PATCH v2] MIPS: math-emu: do not use bools for arithmetic
From: Maciej W. Rozycki <hidden>
Date: 2017-08-14 11:25:33
From: Maciej W. Rozycki <hidden>
Date: 2017-08-14 11:25:33
On Mon, 14 Aug 2017, Manuel Lauss wrote:
--- v2: just use xor, as suggested by Maciej. No size changes this time, but still untested due to lack of hardfloat userland.
D'oh, I was wondering what you meant by writing: "binary size reduction" and didn't get that you meant a size reduction of the binary object file produced rather than a transformation made by the compiler to the binary expression used. That looks odd indeed -- have you tried comparing the output from `objdump -d' with and without the original patch applied? Your change looks obviously correct to me, however I can push it through GCC and/or glibc IEEE 754 math regression testing if it'll make you feel more confident about it. Meanwhile: Reviewed-by: Maciej W. Rozycki <redacted> Maciej