# Re: \[PATCH 03/10\] mm: replace get\_user\_pages\_unlocked() write/force parameters with gup\_flags

- From: Jan Kara \<jack@suse.cz\>
- Date: 2016-10-18 12:50:26 
- List: linux-mips
- Page: https://ratatoskr.run/linux-mips/2016/10/112992
- Thread: https://ratatoskr.run/linux-mm/2016/10/113072/t.md

```text
On Thu 13-10-16 01:20:13, Lorenzo Stoakes wrote:
> This patch removes the write and force parameters from get_user_pages_unlocked()
> and replaces them with a gup_flags parameter to make the use of FOLL_FORCE
> explicit in callers as use of this flag can result in surprising behaviour (and
> hence bugs) within the mm subsystem.
> 
> Signed-off-by: Lorenzo Stoakes <redacted>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza
-- 
Jan Kara [ref]
SUSE Labs, CR
```
