[PATCH 4.0 067/105] MIPS: KVM: Do not sign extend on unsigned MMIO load
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2015-06-19 21:11:00
Also in:
kvm, lkml, stable
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2015-06-19 21:11:00
Also in:
kvm, lkml, stable
4.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nicholas Mc Guire <redacted> commit ed9244e6c534612d2b5ae47feab2f55a0d4b4ced upstream. Fix possible unintended sign extension in unsigned MMIO loads by casting to uint16_t in the case of mmio_needed != 2. Signed-off-by: Nicholas Mc Guire <redacted> Reviewed-by: James Hogan <redacted> Tested-by: James Hogan <redacted> Cc: Gleb Natapov <gleb@kernel.org> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: kvm@vger.kernel.org Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/9985/ Signed-off-by: Ralf Baechle <redacted> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- arch/mips/kvm/emulate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/mips/kvm/emulate.c
+++ b/arch/mips/kvm/emulate.c@@ -2101,7 +2101,7 @@ enum emulation_result kvm_mips_complete_ if (vcpu->mmio_needed == 2) *gpr = *(int16_t *) run->mmio.data; else - *gpr = *(int16_t *) run->mmio.data; + *gpr = *(uint16_t *)run->mmio.data; break; case 1: