On Mon, 1 Feb 2021 09:59:47 +0100
Matthias Brugger [off-list ref] wrote:

On 01/02/2021 06:45, Bilal Wasim wrote:

quoted

When "bus_prot_reg_update" is false, the driver should use
INFRA_TOPAXI_PROTECTEN for both setting and clearing the bus
protection. However, the driver does not use this mask for
clearing bus protection which causes failure when booting
the imgtec gpu.

Corrected and tested with mt8173 chromebook.

Signed-off-by: Bilal Wasim <redacted>
---
 drivers/soc/mediatek/mtk-pm-domains.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-pm-domains.h

b/drivers/soc/mediatek/mtk-pm-domains.h index
141dc76054e6..7454c0b4f768 100644 ---
a/drivers/soc/mediatek/mtk-pm-domains.h +++
b/drivers/soc/mediatek/mtk-pm-domains.h @@ -60,7 +60,7 @@
 #define BUS_PROT_UPDATE_TOPAXI(_mask)
	\ BUS_PROT_UPDATE(_mask,				\
 				INFRA_TOPAXI_PROTECTEN,
	\
-				INFRA_TOPAXI_PROTECTEN_CLR,
\
+				INFRA_TOPAXI_PROTECTEN,
	\  

BUS_PROT_UPDATE sets bus_prot_reg_update to true, which contradicts
what you say in the commit message.

Please clarify.

Yes, that's a problem in the commit message - Will fix and send out a
v2.

Thanks,
Bilal

Regards,
Matthias

quoted

 				INFRA_TOPAXI_PROTECTSTA1)
 
 struct scpsys_bus_prot_data {
  

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek