[PATCH v1] fcntl: Remove logically dead code
DORMANTno replies
From: Stanley Chu <hidden>
Date: 2019-02-11 13:43:25
Also in:
linux-fsdevel
Subsystem:
file locking (flock() and fcntl()/lockf()), filesystems (vfs and infrastructure), the rest · Maintainers:
Jeff Layton, Chuck Lever, Alexander Viro, Christian Brauner, Linus Torvalds
The commit d08477aa975e ("fcntl: Don't use ambiguous
SIG_POLL si_codes") added BUG_ON for below case,
(reason - POLL_IN) >= NSIGPOLL
Thus some statements become logically dead code and
can be removed.
Signed-off-by: Stanley Chu <stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
fs/fcntl.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/fcntl.c b/fs/fcntl.c
index 083185174c6d..11ec59bf421c 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c@@ -762,10 +762,7 @@ static void send_sigio_to_task(struct task_struct *p, reasons, otherwise we could leak kernel stack into userspace. */ BUG_ON((reason < POLL_IN) || ((reason - POLL_IN) >= NSIGPOLL)); - if (reason - POLL_IN >= NSIGPOLL) - si.si_band = ~0L; - else - si.si_band = mangle_poll(band_table[reason - POLL_IN]); + si.si_band = mangle_poll(band_table[reason - POLL_IN]); si.si_fd = fd; if (!do_send_sig_info(signum, &si, p, type)) break;
--
2.18.0