[PATCH] media: imx214: Fix the error handling in imx214_probe()
Subsystems:
media input infrastructure (v4l/dvb) , sony imx214 sensor driver , the rest , v4l2 camera sensor drivers
1612d
LANDED
Landed in mainline as 9bc92332cc3f on 2024-04-29.
4 messages,
2 authors,
2022-05-11 · open the first message on its own page
The driver should disable regulators when fails to probe.
Signed-off-by: Zheyu Ma <redacted>
---
drivers/media/i2c/imx214.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index 83c1737abeec..61eeaefd4298 100644
--- a/drivers/media/i2c/imx214.c
+++ b/drivers/media/i2c/imx214.c @@ -1076,6 +1076,7 @@ static int imx214_probe(struct i2c_client *client)
mutex_destroy ( & imx214 -> mutex );
v4l2_ctrl_handler_free ( & imx214 -> ctrls );
pm_runtime_disable ( imx214 -> dev );
+ regulator_bulk_disable ( IMX214_NUM_SUPPLIES , imx214 -> supplies );
return ret ;
} --
2.25.1
Hi Zheyu
Do you have seen this issue in a real hardware? The device enters
idle state unconditionally after power_on during probe.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/i2c/imx214.c#n1008
On Tue, May 10, 2022 at 1:49 PM Zheyu Ma [off-list ref] wrote: quoted hunk
The driver should disable regulators when fails to probe.
Signed-off-by: Zheyu Ma <redacted>
---
drivers/media/i2c/imx214.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index 83c1737abeec..61eeaefd4298 100644
--- a/drivers/media/i2c/imx214.c
+++ b/drivers/media/i2c/imx214.c @@ -1076,6 +1076,7 @@ static int imx214_probe(struct i2c_client *client)
mutex_destroy ( & imx214 -> mutex );
v4l2_ctrl_handler_free ( & imx214 -> ctrls );
pm_runtime_disable ( imx214 -> dev );
+ regulator_bulk_disable ( IMX214_NUM_SUPPLIES , imx214 -> supplies ); return ret ;
}
- - 2.25.1
On Wed, May 11, 2022 at 8:19 PM Ricardo Ribalda Delgado
[off-list ref] wrote:
Hi Zheyu
Do you have seen this issue in a real hardware? The device enters
idle state unconditionally after power_on during probe.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/i2c/imx214.c#n1008
Actually I didn't, I found the "bug" manually.
Thanks for your reminder and sorry for the false alarm.
Zheyu Ma
Hi
On Wed, May 11, 2022 at 4:04 PM Zheyu Ma [off-list ref] wrote:
On Wed, May 11, 2022 at 8:19 PM Ricardo Ribalda Delgado
[off-list ref] wrote: quoted
Hi Zheyu
Do you have seen this issue in a real hardware? The device enters
idle state unconditionally after power_on during probe.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/i2c/imx214.c#n1008
Actually I didn't, I found the "bug" manually.
Thanks for your reminder and sorry for the false alarm.
Thank you for looking at the code :)
Zheyu Ma