[PATCH v3 00/19] CAMSS: Add SM8250 support
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Date: 2021-12-22 00:35:48
V3:
Publishing this V3 to make it a bit easier to merge
- Adds Rob Herring's RB for the first DTS change
- Adds Robert Foss' RB for the final three patches
- Validated on latest 5.16-rc6 on rb3 and rb5
- No functional changes to v2
Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/commit/?h=v5.16-rc6-sm8250-camss-imx577-only-v3
Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/commit/?h=v5.16-rc3-sm8250-camss-imx577-only-v2
RESEND V2:
+ Cc: devicetree@vger.kernel.org on first patch
V2:
- Adds Tested-by Julian Grahsl as indicated.
- Fixes low-level noise checkpatch --strict
I ended up having to push defines into static inlines for this.
- Adds Reviewed-by Robert Foss.
- Adds VFE/CSID fix for sdm845 as explicit additional sdm845 specific
patch per Robert's suggestion.
I took the time then to test out on sdm845 to ensure the new patch breaks
nothing "./cam -c 1 --capture=1 --file=capture.raw" continues to produce
expected data.
Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/commit/?h=v5.16-rc1-sm8250-camss-imx577-only
Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/commit/?h=v5.16-rc3-sm8250-camss-imx577-only-v2
git diff v5.16-rc1-sm8250-camss-imx577-only..v5.16-rc3-sm8250-camss-imx577-only-v2 -- drivers/media/platform/qcom/camss
V1/RESEND:
RESEND: git send-email --to=inux-arm-msm@vger.kernel.org -> --to=linux-arm-msm@vger.kernel.org
This series is imported from excellent enabling work contributed by
Jonathan Marek which we have picked up in Linaro for the RB5 project.
Link: https://patchwork.kernel.org/project/linux-arm-msm/patch/20210511180728.23781-2-jonathan@marek.ca/
Link: https://www.qualcomm.com/products/robotics-rb5-platform
Link: https://www.96boards.org/product/qualcomm-robotics-rb5
Link: https://www.thundercomm.com/app_en/product/1590131656070623?index=1&categoryId=category0&tabIndex=1
The RB5 has a slightly different sku I think to Jonathan's platform -
QRB5165 in our case with a different version of LK the relevant bootloader
for the board.
As a result we needed to make some additional updates to the provided
patcheset, included here.
The most notable changes are:
- Addition of clocks.
- Addition of bandwidth settings.
- Representing the dependency on a VFE for a given CSID so that V4L
subdevs will come out of reset right when poked.
A full tree which is bootable and capable of producing pixel data from the
imx577 main sensor is available here, with this series being a sub-set of
the necessary patches on the SoC side only.
Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=v5.16-rc1-sm8250-camss-imx577-only
media-ctl --reset
media-ctl -v -d /dev/media0 -V '"imx412 '20-001a'":0[fmt:SRGGB10/4056x3040 field:none]'
media-ctl -V '"msm_csiphy2":0[fmt:SRGGB10/4056x3040]'
media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]'
media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]'
media-ctl -l '"msm_csiphy2":1->"msm_csid0":0[1]'
media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video0
Bryan O'Donoghue (3):
media: camss: Add SM8250 bandwdith configuration support
media: camss: Do vfe_get/vfe_put for csid on sm8250
media: camss: Apply vfe_get/vfe_put fix to SDM845
Jonathan Marek (16):
media: dt-bindings: media: camss: Add qcom,sm8250-camss binding
media: camss: csiphy-3ph: don't print HW version as an error
media: camss: csiphy-3ph: disable interrupts
media: camss: csiphy-3ph: add support for SM8250 CSI DPHY
media: camss: csid-170: fix non-10bit formats
media: camss: csid-170: don't enable unused irqs
media: camss: csid-170: remove stray comment
media: camss: csid-170: support more than one lite vfe
media: camss: csid-170: set the right HALT_CMD when disabled
media: camss: csid: allow csid to work without a regulator
media: camss: remove vdda-csiN from sdm845 resources
media: camss: fix VFE irq name
media: camss: vfe-170: fix "VFE halt timeout" error
media: camss: Add initial support for VFE hardware version Titan 480
media: camss: add support for V4L2_PIX_FMT_GREY for sdm845 HW
media: camss: add support for SM8250 camss
.../bindings/media/qcom,sm8250-camss.yaml | 450 ++++++++++++++
drivers/media/platform/qcom/camss/Makefile | 3 +-
.../{camss-csid-170.c => camss-csid-gen2.c} | 32 +-
.../media/platform/qcom/camss/camss-csid.c | 56 +-
.../media/platform/qcom/camss/camss-csid.h | 2 +-
.../qcom/camss/camss-csiphy-3ph-1-0.c | 184 ++++--
.../media/platform/qcom/camss/camss-csiphy.c | 9 +-
.../media/platform/qcom/camss/camss-vfe-170.c | 12 +-
.../media/platform/qcom/camss/camss-vfe-480.c | 564 ++++++++++++++++++
drivers/media/platform/qcom/camss/camss-vfe.c | 17 +-
drivers/media/platform/qcom/camss/camss-vfe.h | 4 +
.../media/platform/qcom/camss/camss-video.c | 5 +-
drivers/media/platform/qcom/camss/camss.c | 306 +++++++++-
drivers/media/platform/qcom/camss/camss.h | 18 +
14 files changed, 1558 insertions(+), 104 deletions(-)
create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml
rename drivers/media/platform/qcom/camss/{camss-csid-170.c => camss-csid-gen2.c} (95%)
create mode 100644 drivers/media/platform/qcom/camss/camss-vfe-480.c
--
2.33.0