[PATCH] media: staging: bcm2048: use unsigned int instead of unsigned

Subsystems: media input infrastructure (v4l/dvb), staging subsystem, the rest

STALE3450d

4 messages, 3 authors, 2017-02-21 · open the first message on its own page

[PATCH] media: staging: bcm2048: use unsigned int instead of unsigned

From: David Cako <hidden>
Date: 2017-02-21 00:09:28 

Signed-off-by: David Cako <redacted>
---
 drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +++++++++++++--------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 37bd439..b1923a3 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2020,27 +2020,27 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,		\
 	return count;							\
 }
 
-DEFINE_SYSFS_PROPERTY(power_state, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(mute, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(audio_route, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(dac_output, unsigned, int, "%u", 0)
-
-DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned, int, "%u", value > 3)
-
-DEFINE_SYSFS_PROPERTY(rds, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_wline, unsigned, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
+
+DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned int, int, "%u", value > 3)
+
+DEFINE_SYSFS_PROPERTY(rds, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_wline, unsigned int, int, "%u", 0)
 property_read(rds_pi, unsigned int, "%x")
 property_str_read(rds_rt, (BCM2048_MAX_RDS_RT + 1))
 property_str_read(rds_ps, (BCM2048_MAX_RDS_PS + 1))
@@ -2052,7 +2052,7 @@ property_read(region_bottom_frequency, unsigned int, "%u")
 property_read(region_top_frequency, unsigned int, "%u")
 property_signed_read(fm_carrier_error, int, "%d")
 property_signed_read(fm_rssi, int, "%d")
-DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(region, unsigned int, int, "%u", 0)
 
 static struct device_attribute attrs[] = {
 	__ATTR(power_state, 0644, bcm2048_power_state_read,
-- 
2.7.4

[PATCH] fix unsigned int argument

From: David Cako <hidden>
Date: 2017-02-21 01:35:19 

Sorry, left the old "int" argument in previous patch.

Signed-off-by: David Cako <redacted>
---
 drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +++++++++++++--------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index b1923a3..a41d971 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2020,27 +2020,27 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,		\
 	return count;							\
 }
 
-DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
-
-DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned int, int, "%u", value > 3)
-
-DEFINE_SYSFS_PROPERTY(rds, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned int, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_wline, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(power_state, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(mute, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, "%u", 0)
+
+DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned int, "%u", value > 3)
+
+DEFINE_SYSFS_PROPERTY(rds, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_wline, unsigned int, "%u", 0)
 property_read(rds_pi, unsigned int, "%x")
 property_str_read(rds_rt, (BCM2048_MAX_RDS_RT + 1))
 property_str_read(rds_ps, (BCM2048_MAX_RDS_PS + 1))
@@ -2052,7 +2052,7 @@ property_read(region_bottom_frequency, unsigned int, "%u")
 property_read(region_top_frequency, unsigned int, "%u")
 property_signed_read(fm_carrier_error, int, "%d")
 property_signed_read(fm_rssi, int, "%d")
-DEFINE_SYSFS_PROPERTY(region, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(region, unsigned int, "%u", 0)
 
 static struct device_attribute attrs[] = {
 	__ATTR(power_state, 0644, bcm2048_power_state_read,
-- 
2.7.4

Re: [PATCH] media: staging: bcm2048: use unsigned int instead of unsigned

From: kbuild test robot <hidden>
Date: 2017-02-21 01:37:27 

Hi David,

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.10 next-20170220]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/David-Cako/media-staging-bcm2048-use-unsigned-int-instead-of-unsigned/20170221-082741
base:   git://linuxtv.org/media_tree.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_power_state_write':
quoted
drivers/staging/media/bcm2048/radio-bcm2048.c:2023:50: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
                                                     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2023:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_mute_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2024:43: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
                                              ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2024:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_audio_route_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2025:50: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
                                                     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2025:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_dac_output_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2026:49: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
                                                    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2026:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_hi_lo_injection_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2028:57: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
                                                            ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2028:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_frequency_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2029:51: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
                                                      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2029:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_af_frequency_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2030:54: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
                                                         ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2030:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_deemphasis_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2031:52: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
                                                       ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2031:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_rds_mask_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2032:50: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
                                                     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2032:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_best_tune_mode_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2033:56: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
                                                           ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2033:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_search_rssi_threshold_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2034:63: error: two or more data types in declaration specifiers

vim +2023 drivers/staging/media/bcm2048/radio-bcm2048.c

  2017										\
  2018		kfree(out);							\
  2019										\
  2020		return count;							\
  2021	}
  2022	
2023	DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
  2024	DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
  2025	DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
  2026	DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Re: [PATCH] media: staging: bcm2048: use unsigned int instead of unsigned

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2017-02-21 04:49:46 

On Mon, Feb 20, 2017 at 05:08:56PM -0700, David Cako wrote:
Signed-off-by: David Cako <redacted>
---
 drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +++++++++++++--------------
 1 file changed, 22 insertions(+), 22 deletions(-)
We can't take patches without any changelog text, sorry.  And always
test-build your patches, this is a known tricky one, you have to ignore
checkpatch, it is wrong.

sorry,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help