Re: [PATCH v3] man/man2/statmount.2: Document STATMOUNT_BY_FD
From: Alejandro Colomar <alx@kernel.org>
Date: 2026-03-05 22:45:17
Hi Branden, On 2026-03-05T16:24:31-0600, G. Branden Robinson wrote:
[CC list trimmed way down since this is a *roff/formatting issue] Hi Alex, At 2026-03-05T18:19:30+0100, Alejandro Colomar wrote:quoted
BTW, Branden, I'm getting a diagnostic from groff: TROFF .tmp/man/man2/statmount.2.pdf.set ! (troff -mandoc -Tpdf -wbreak -rS12 -rU0 <.tmp/man/man2/statmount.2.pdf.troff 2>&1 >.tmp/man/man2/statmount.2.pdf.set) \ | grep ^ >&2 .tmp/man/man2/statmount.2:155: warning: table row does not fit on page 2 But the PDF looks good to me. Would you mind looking at that page and telling me what you'd do with that diagnostic, and whether I should care about it?I can't reproduce this diagnostic with groff 1.23.0 or 1.24.0.
Huh... I'm reproducing it on my server, but not on my desktop. On my server, I have: GNU troff (groff) version 1.23.0.1254-19a18 On my desktop, I have: GNU grops (groff) version 1.23.0.2695-49927 I'll assume this is a fixed issue, since the newer groff(1) from my desktop doesn't reproduce it.
quoted
.tmp/man/man2/statmount.2:155: warning: table row does not fit on page 2This warning means that a row of the table might be vertically encroaching into the footer margin; in extreme cases, might overprint the page footer itself; and in really loony cases, format text beyond the bottom of the page.
Yeah, that's what I was expecting, but the page renders fine, and I don't see anything near the margins, which made it weird.
My copy of the document is this one: commit 7178f0e15db66a3616a900fc8a4007466633159b Author: Bhavik Sachdev [off-list ref] Date: Thu Feb 26 08:40:16 2026 +0530
Yup, that's correct.
$ ~/groff-1.24.0/bin/groff -t -ww -mandoc -Tpdf -rS12 -rU0 -z \
man/man2/statmount.2 2>&1 | grep . || echo NO DIAGNOSTICS
NO DIAGNOSTICS
$ ~/groff-1.23.0/bin/groff -t -ww -mandoc -Tpdf -rS12 -rU0 -z \
man/man2/statmount.2 2>&1 | grep . || echo NO DIAGNOSTICS
NO DIAGNOSTICS
As you can see, I've turned on _all_ warnings (`-ww`).
Looking at the table source:
$ sed -n '154,171p' man/man2/statmount.2
.TS
lB l.
STATMOUNT_SB_BASIC /* Want/got sb_* */
STATMOUNT_MNT_BASIC /* Want/got mnt_* */
STATMOUNT_PROPAGATE_FROM /* Want/got propagate_from */
STATMOUNT_MNT_ROOT /* Want/got mnt_root */
STATMOUNT_MNT_POINT /* Want/got mnt_point */
STATMOUNT_FS_TYPE /* Want/got fs_type */
STATMOUNT_MNT_NS_ID /* Want/got mnt_ns_id */
STATMOUNT_MNT_OPTS /* Want/got mnt_opts */
STATMOUNT_FS_SUBTYPE /* Want/got fs_subtype */
STATMOUNT_SB_SOURCE /* Want/got sb_source */
STATMOUNT_OPT_ARRAY /* Want/got opt_{num,array} */
STATMOUNT_OPT_SEC_ARRAY /* Want/got opt_sec_{num,array} */
STATMOUNT_MNT_UIDMAP /* Want/got uidmap{_num,} */
STATMOUNT_MNT_GIDMAP /* Want/got gidmap{_num,} */
STATMOUNT_SUPPORTED_MASK /* Want/got supported mask flags */
.TE
...I don't see any reason why you should get that diagnostic.
1. You're not using any text blocks. Text blocks are formatted in a
diversion and contain (line) breaks, so they can get "tall".
2. You're not using any other features to make a table row "tall", for
example by performing "local motion" with the `\v` escape sequence.
Formatting equations in a table cell is the more traditional means
of encountering this problem.
Can you reproduce this problem from the command line, without using your
Makefile?Yup. On my server: $ groff -t -ww -mandoc -Tpdf -rS12 -rU0 -z man/man2/statmount.2 2>&1 \ | grep . \ || echo NO DIAGNOSTICS; man/man2/statmount.2:155: warning: table row does not fit on page 2 Using $ groff --version | tail -n1 GNU troff (groff) version 1.23.0.1254-19a18 Have a lovely night! Alex -- <https://www.alejandro-colomar.es>
Attachments
- signature.asc [application/pgp-signature] 833 bytes