Thread (27 messages) 27 messages, 4 authors, 2025-11-05

Re: [PATCH leds v2 06/10] leds: core: inform trigger that it's deactivation is due to LED removal

From: Marek Behún <kabel@kernel.org>
Date: 2021-06-02 12:44:50
Also in: netdev

On Tue, 1 Jun 2021 23:12:57 +0200
Andrew Lunn [off-list ref] wrote:
On Tue, Jun 01, 2021 at 02:51:51AM +0200, Marek Behún wrote:
quoted
Move setting of the LED_UNREGISTERING before deactivating the
trigger in led_classdev_unregister().

It can be useful for a LED trigger to know whether it is being
deactivated due to the LED being unregistered. This makes it
possible for LED drivers which implement trigger offloading to
leave the LED in HW triggering mode when the LED is unregistered,
instead of disabling it.  
Humm, i'm not sure that is a good idea. I don't expect my Ethernet
switch to keep forwarding frames when i unload the driver.
We want to make it so that when leds-turris-omnia driver is unloaded,
the LEDs will start blinking in HW mode as they did before the driver
was loaded. This is needed for that.

Marek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help