[PATCH] drivers: mtd: ubi: fixed a semicolon style issue in block.c

fixed a small coding style issue in using semicolon.

signed-off-by: Rahul Balaji <redacted>
---
 drivers/mtd/ubi/block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
index e003b4b44ffa..e0402c2f8959 100644
--- a/drivers/mtd/ubi/block.c
+++ b/drivers/mtd/ubi/block.c

@@ -405,7 +405,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
 	ret = blk_mq_alloc_tag_set(&dev->tag_set);
 	if (ret) {
 		dev_err(disk_to_dev(dev->gd), "blk_mq_alloc_tag_set failed");
-		goto out_free_dev;;
+		goto out_free_dev;
 	}
 
 

-- 
2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

respected mentor,

I have sent the first patch only as per the task. please do give me your
confirmation so that i can proceed further with the other patches too

Thank you,
sincerely,
rahul.

On Mon, Aug 2, 2021 at 2:06 AM Rahul Balaji [off-list ref] wrote:

sorry for that slight misunderstanding. i thought the first patch meant
only a small test patch for the first file. I will send the other changes
shortly too.

Thank you for your understanding.

yours sincerely,
Rahul.



On Mon, Aug 2, 2021 at 2:10 AM Rahul Balaji [off-list ref] wrote:

respected mentor,

I have sent the first patch only as per the task. please do give me your
confirmation so that i can proceed further with the other patches too

Thank you,
sincerely,
rahul.

On Mon, Aug 2, 2021 at 2:06 AM Rahul Balaji [off-list ref]
wrote:

quoted

fixed a small coding style issue in using semicolon.

signed-off-by: Rahul Balaji <redacted>
---
 drivers/mtd/ubi/block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
index e003b4b44ffa..e0402c2f8959 100644
--- a/drivers/mtd/ubi/block.c
+++ b/drivers/mtd/ubi/block.c

@@ -405,7 +405,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
        ret = blk_mq_alloc_tag_set(&dev->tag_set);
        if (ret) {
                dev_err(disk_to_dev(dev->gd), "blk_mq_alloc_tag_set

failed");
-               goto out_free_dev;;
+               goto out_free_dev;
        }


--
2.25.1

Use imperative: Subject line shall be in imperative form.

On Mon, Aug 2, 2021 at 12:06 AM Rahul Balaji [off-list ref] wrote:

fixed a small coding style issue in using semicolon.

Mention your motivation, i.e., the investigation of the ONE_SEMICOLON rule.

Mention if this change modifies the code's behaviour.

If not, add to the comment message:

"No functional change."

signed-off-by: Rahul Balaji <redacted>

signed-off-by is written as "Signed-off-by:".

Did you run checkpatch on your patch? What is the checkpatch output
running your patch? Please share that with us.

Give it another try and create a PATCH v2.

Lukas

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees